Added Android device commands by SrinivasanTarget · Pull Request #518 · appium/java-client

SrinivasanTarget · Nov 19, 2016

Change list

Added Android device commands

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Added Android device commands

isKeyboardShown
getDisplayDensity
getSystemBars

Added,
io.appium.java_client.android.IsKeyboardShown API and
io.appium.java_client.HasDeviceDetails API.

@TikhomirovSergey Please review

…ouchActionSplitting

…arget/java-client into SrinivasanTarget-TouchActionSplitting

- new interfaces were added - deprecated API

- new methods were added to MultiTouchAction - AppiumDriver methods which perform multiple touch actions were marked as Deprecated - Constructors of TouchAction and MultiTouchAction were changed. Now it accepts any instance that can perform touch action and multiple touch actions.

- the new interface CreatesSwipeAction was added. - the reversion of last changes of TouchableElement. - the `swipe` is deprecated method.

Forgot to commit this change

- CreatesSwipeAction API was implemented - SwipeElementDirection was redesigned - constructors of TouchAction and MultiTouchAction were improved.

- also code issues were got fixed

- IOSSwipeGestureTest was added

- the swiping combined with the tapping.

…b.com/TikhomirovSergey/java-client into TikhomirovSergey-SrinivasanTarget-TouchActionSplitting

Fixed Codacy errors Fixed Codacy errors

…ikhomirovSergey-SrinivasanTarget-TouchActionSplitting

… of https://github.com/SrinivasanTarget/java-client into AndroidDeviceCommands

SrinivasanTarget · Nov 21, 2016

@imurchie Can you please check this? https://gist.github.com/SrinivasanTarget/d564095d2009779bed69a2d6ef8f0b8e.

I'm running from source with latest android driver and base driver.

imurchie · Nov 22, 2016

@SrinivasanTarget This should be a GET request. https://github.com/appium/appium-base-driver/blob/master/lib/mjsonwp/routes.js#L333

SrinivasanTarget · Nov 22, 2016

@TikhomirovSergey Have fixed this PR. Tested this on Android 6.0 and it works as expected.

Refractoring

TikhomirovSergey · Nov 24, 2016

This PR is in the conflicted state

SrinivasanTarget · Nov 24, 2016

Yup @TikhomirovSergey Will close this and raise a new one probably in sometime.

…ndroidDeviceCommands

SrinivasanTarget · Nov 24, 2016

@TikhomirovSergey I have rebased this to master and fixed the conflicts now.

TikhomirovSergey · Nov 25, 2016

src/main/java/io/appium/java_client/HasDeviceDetails.java

+
+import java.util.Map;
+
+public interface HasDeviceDetails extends ExecutesMethod {


It seems that methods that declared by this interface are Android-specific. Please take a look at
https://github.com/search?q=org%3Aappium+DISPLAY+DENSITY&type=Code

https://github.com/search?q=org%3Aappium+GET+SYSTEM+BARS&type=Code

I think it has more sense to move this interface to the io.appium.java_client.android

TikhomirovSergey · Nov 25, 2016

src/main/java/io/appium/java_client/android/IsKeyboardShown.java

+import io.appium.java_client.CommandExecutionHelper;
+import io.appium.java_client.ExecutesMethod;
+
+public interface IsKeyboardShown extends ExecutesMethod {


I think it has more sense to unite this interface with HasDeviceDetails

TikhomirovSergey · Nov 25, 2016

src/test/java/io/appium/java_client/android/AndroidSearchingTest.java

        assertNotNull(radioGroup.getLocation());
    }
+
+    @Test public void deviceDetailsAndKeyboardTest() {


Why this method is here? Maybe it has more sense to move it to AndroidDriverTest

SrinivasanTarget · Nov 25, 2016

@TikhomirovSergey Fixed review comments now

SrinivasanTarget · Nov 26, 2016

@TikhomirovSergey Ping

SrinivasanTarget and others added 20 commits August 12, 2016 00:13

Splitting of TouchActions

b6aa487

Codacy Fixes

d76bad8

Merge branch 'master' of https://github.com/appium/java-client into T…

1909222

…ouchActionSplitting

Merge branch 'TouchActionSplitting' of https://github.com/SrinivasanT…

b5bc4e6

…arget/java-client into SrinivasanTarget-TouchActionSplitting

#456 FIX #454 FIX: API redesign.

ffbb4de

- new interfaces were added - deprecated API

#456 FIX #454 FIX: New CreatesSwipeAction API

34a718b

- the new interface CreatesSwipeAction was added. - the reversion of last changes of TouchableElement. - the `swipe` is deprecated method.

#456 FIX #454 FIX:

e890280

Forgot to commit this change

#456 FIX #454 FIX: CreatesSwipeAction API was implemented

4b87991

- CreatesSwipeAction API was implemented - SwipeElementDirection was redesigned - constructors of TouchAction and MultiTouchAction were improved.

#456 FIX #454 FIX: AndroidTouchActions were covered with tests.

f799d34

- also code issues were got fixed

#456 FIX #454 FIX: Refactoring of MobileElement

f07ac6e

#456 FIX #454 FIX: IOSGesturesTest was redesigned.

980b6a1

- IOSSwipeGestureTest was added

#456 FIX #454 FIX: Checkstyle issues were got fixed

d832a19

#456 FIX #454 FIX: The additional test on Android.

f8ad455

- the swiping combined with the tapping.

Issues that found by codecy were got fixed

2ba3652

Merge branch 'SrinivasanTarget-TouchActionSplitting' of https://githu…

5b9a7c0

…b.com/TikhomirovSergey/java-client into TikhomirovSergey-SrinivasanTarget-TouchActionSplitting

The addition #513

f9a928e

Fixed Codacy errors Fixed Codacy errors

Merge branch 'master' of https://github.com/appium/java-client into T…

da9064b

…ikhomirovSergey-SrinivasanTarget-TouchActionSplitting

Added isKeyboardShown,getDisplayDensity and getSystemBars Commands

9ae8606

Fixed Tests

d42df2b

SrinivasanTarget added Android enhancement labels Nov 19, 2016

SrinivasanTarget added this to the 5.0.0 milestone Nov 19, 2016

Merge branch 'TikhomirovSergey-SrinivasanTarget-TouchActionSplitting'…

b63df4b

… of https://github.com/SrinivasanTarget/java-client into AndroidDeviceCommands

Refractoring

db74f17

Refractoring

SrinivasanTarget assigned TikhomirovSergey Nov 24, 2016

SrinivasanTarget added 2 commits November 24, 2016 20:55

Merge branch 'master' of https://github.com/appium/java-client into A…

b2b5c14

…ndroidDeviceCommands

Fixed styling issues

a3fdeda

TikhomirovSergey suggested changes Nov 25, 2016

View reviewed changes

Fixed review comments

20ba018

Fixed review comments

358bdce

TikhomirovSergey approved these changes Nov 26, 2016

View reviewed changes

TikhomirovSergey merged commit 24c7747 into appium:master Nov 26, 2016

SrinivasanTarget deleted the AndroidDeviceCommands branch February 25, 2017 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added Android device commands#518

Added Android device commands#518
TikhomirovSergey merged 26 commits intoappium:masterappium/java-client:masterfrom
SrinivasanTarget:AndroidDeviceCommandsCopy head branch name to clipboard

SrinivasanTarget commented Nov 19, 2016 •

edited

Loading

Uh oh!

SrinivasanTarget commented Nov 21, 2016

Uh oh!

imurchie commented Nov 22, 2016

Uh oh!

SrinivasanTarget commented Nov 22, 2016 •

edited

Loading

Uh oh!

TikhomirovSergey commented Nov 24, 2016

Uh oh!

SrinivasanTarget commented Nov 24, 2016

Uh oh!

SrinivasanTarget commented Nov 24, 2016

Uh oh!

TikhomirovSergey Nov 25, 2016

Uh oh!

TikhomirovSergey Nov 25, 2016

Uh oh!

TikhomirovSergey Nov 25, 2016

Uh oh!

SrinivasanTarget commented Nov 25, 2016

Uh oh!

SrinivasanTarget commented Nov 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import java.util.Map;

		public interface HasDeviceDetails extends ExecutesMethod {

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

SrinivasanTarget commented Nov 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change list

Types of changes

Details

Uh oh!

SrinivasanTarget commented Nov 21, 2016

Uh oh!

imurchie commented Nov 22, 2016

Uh oh!

SrinivasanTarget commented Nov 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TikhomirovSergey commented Nov 24, 2016

Uh oh!

SrinivasanTarget commented Nov 24, 2016

Uh oh!

SrinivasanTarget commented Nov 24, 2016

Uh oh!

TikhomirovSergey Nov 25, 2016

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey Nov 25, 2016

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey Nov 25, 2016

Choose a reason for hiding this comment

Uh oh!

SrinivasanTarget commented Nov 25, 2016

Uh oh!

SrinivasanTarget commented Nov 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SrinivasanTarget commented Nov 19, 2016 •

edited

Loading

SrinivasanTarget commented Nov 22, 2016 •

edited

Loading