The addition #458. #456 FIX #454 FIX#513
Closed
TikhomirovSergey wants to merge 15 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:SrinivasanTarget-TouchActionSplittingCopy head branch name to clipboard
Closed
The addition #458. #456 FIX #454 FIX#513TikhomirovSergey wants to merge 15 commits intoappium:masterappium/java-client:masterfrom TikhomirovSergey:SrinivasanTarget-TouchActionSplittingCopy head branch name to clipboard
TikhomirovSergey wants to merge 15 commits intoappium:masterappium/java-client:masterfrom
TikhomirovSergey:SrinivasanTarget-TouchActionSplittingCopy head branch name to clipboard
Conversation
…ouchActionSplitting
…arget/java-client into SrinivasanTarget-TouchActionSplitting
- new interfaces were added - deprecated API
- new methods were added to MultiTouchAction - AppiumDriver methods which perform multiple touch actions were marked as Deprecated - Constructors of TouchAction and MultiTouchAction were changed. Now it accepts any instance that can perform touch action and multiple touch actions.
- the new interface CreatesSwipeAction was added. - the reversion of last changes of TouchableElement. - the `swipe` is deprecated method.
- CreatesSwipeAction API was implemented - SwipeElementDirection was redesigned - constructors of TouchAction and MultiTouchAction were improved.
- also code issues were got fixed
- IOSSwipeGestureTest was added
- the swiping combined with the tapping.
TikhomirovSergey
pushed a commit
that referenced
this pull request
Nov 24, 2016
* Splitting of TouchActions * Codacy Fixes * #456 FIX #454 FIX: API redesign. - new interfaces were added - deprecated API * #456 FIX #454 FIX: MultiTouchAction refactoring - new methods were added to MultiTouchAction - AppiumDriver methods which perform multiple touch actions were marked as Deprecated - Constructors of TouchAction and MultiTouchAction were changed. Now it accepts any instance that can perform touch action and multiple touch actions. * #456 FIX #454 FIX: New CreatesSwipeAction API - the new interface CreatesSwipeAction was added. - the reversion of last changes of TouchableElement. - the `swipe` is deprecated method. * #456 FIX #454 FIX: Forgot to commit this change * #456 FIX #454 FIX: CreatesSwipeAction API was implemented - CreatesSwipeAction API was implemented - SwipeElementDirection was redesigned - constructors of TouchAction and MultiTouchAction were improved. * #456 FIX #454 FIX: AndroidTouchActions were covered with tests. - also code issues were got fixed * #456 FIX #454 FIX: Refactoring of MobileElement * #456 FIX #454 FIX: IOSGesturesTest was redesigned. - IOSSwipeGestureTest was added * #456 FIX #454 FIX: Checkstyle issues were got fixed * #456 FIX #454 FIX: The additional test on Android. - the swiping combined with the tapping. * Issues that found by codecy were got fixed * The addition #513 Fixed Codacy errors Fixed Codacy errors * Fixed tests Fixed tests Fixed tests Fixed tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
The addition #458. #456 FIX #454 FIX:
AppiumDriveris the non-abstract class now;MobileElementis the non-abstract class now;AppiumDriver#swipe(int, int, int, int, int)AppiumDriver#pinch(WebElement)AppiumDriver#pinch(int, int)AppiumDriver#zoom(WebElement)AppiumDriver#zoom(int, int)AppiumDriver#tap(int, WebElement, int)AppiumDriver#tap(int, int, int, int)AppiumDriver#swipe(int, int, int, int, int)MobileElement#swipe(SwipeElementDirection, int)MobileElement#swipe(SwipeElementDirection, int, int, int)io.appium.java_client.DeviceActionShortcutsio.appium.java_client.android.AndroidDeviceActionShortcutsio.appium.java_client.ios.IOSDeviceActionShortcutsio.appium.java_client.HasDeviceTimeio.appium.java_client.HidesKeyboardio.appium.java_client.HidesKeyboardWithKeyNameio.appium.java_client.PressesKeyCodeio.appium.java_client.ios.ShakesDeviceThat was done because Windows automation tools have some features that were considered as Android-specific and iOS-specific.
io.appium.java_client.CreatesSwipeActionTouchActionandMultiTouchActionAppiumDriverandTouchAction/MultiTouchAction. They can pass any instance of a class that implementsPerformsTouchActions.AppiumDriver/MobileElementwere moved toTouchAction/MultiTouchAction.io.appium.java_client.android.AndroidTouchActionandio.appium.java_client.ios.IOSTouchActionwere added. They create the swiping gesture. Both classes implement the newio.appium.java_client.CreatesSwipeActionAPI.Types of changes