Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: Fix type of cloud_storage_client in SmartApifyStorageClient#642

Merged
vdusek merged 1 commit into
masterapify/apify-sdk-python:masterfrom
polish-smart-apify-storage-clientapify/apify-sdk-python:polish-smart-apify-storage-clientCopy head branch name to clipboard
Oct 23, 2025
Merged

fix: Fix type of cloud_storage_client in SmartApifyStorageClient#642
vdusek merged 1 commit into
masterapify/apify-sdk-python:masterfrom
polish-smart-apify-storage-clientapify/apify-sdk-python:polish-smart-apify-storage-clientCopy head branch name to clipboard

Conversation

@vdusek

@vdusek vdusek commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

The type of cloud_storage_client in SmartApifyStorageClient should be StorageClient, not just ApifyStorageClient, as we want to support using other storage clients on the Apify platform as well.

Other minor changes:

  • I've also updated the method order for consistency: constants -> public -> private.
  • ApifyStorageClient is in single access mode by default.

@vdusek vdusek added this to the 126th sprint - Tooling team milestone Oct 22, 2025
@vdusek
vdusek requested a review from Pijukatel October 22, 2025 13:54
@vdusek vdusek self-assigned this Oct 22, 2025
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 22, 2025
@vdusek
vdusek merged commit 3bf285d into master Oct 23, 2025
22 checks passed
@vdusek
vdusek deleted the polish-smart-apify-storage-client branch October 23, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.