Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: add test for storage actor methods#39

Merged
drobnikj merged 6 commits into
masterapify/apify-sdk-python:masterfrom
feat/actor_storage_method_testsapify/apify-sdk-python:feat/actor_storage_method_testsCopy head branch name to clipboard
Jan 31, 2023
Merged

feat: add test for storage actor methods#39
drobnikj merged 6 commits into
masterapify/apify-sdk-python:masterfrom
feat/actor_storage_method_testsapify/apify-sdk-python:feat/actor_storage_method_testsCopy head branch name to clipboard

Conversation

@drobnikj

Copy link
Copy Markdown
Member

No description provided.

@fnesveda fnesveda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Comment thread tests/unit/actor/test_actor_key_value_store.py Outdated
@drobnikj
drobnikj requested a review from jirimoravcik January 30, 2023 12:43
@github-actions github-actions Bot added this to the 56th sprint - Platform team milestone Jan 30, 2023
@github-actions github-actions Bot added the t-core-services Issues with this label are in the ownership of the core services team. label Jan 30, 2023

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Comment thread tests/unit/actor/test_actor_dataset.py Outdated
@drobnikj
drobnikj requested a review from jirimoravcik January 31, 2023 11:02
memory_storage: MemoryStorage,
) -> None:
default_dataset_name = 'my-new-default-name'
await memory_storage.datasets().get_or_create(name=default_dataset_name)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line even needed?

@drobnikj
drobnikj merged commit b89bbcf into master Jan 31, 2023
@drobnikj
drobnikj deleted the feat/actor_storage_method_tests branch January 31, 2023 13:17
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.