feat: docs string for memory storage clients#31
Merged
drobnikj merged 5 commits intoJan 30, 2023
masterapify/apify-sdk-python:masterfrom
feat/docs_strings_memory_storageapify/apify-sdk-python:feat/docs_strings_memory_storageCopy head branch name to clipboard
Merged
feat: docs string for memory storage clients#31drobnikj merged 5 commits intomasterapify/apify-sdk-python:masterfrom feat/docs_strings_memory_storageapify/apify-sdk-python:feat/docs_strings_memory_storageCopy head branch name to clipboard
drobnikj merged 5 commits into
masterapify/apify-sdk-python:masterfrom
feat/docs_strings_memory_storageapify/apify-sdk-python:feat/docs_strings_memory_storageCopy head branch name to clipboard
Conversation
jirimoravcik
approved these changes
Jan 24, 2023
fnesveda
requested changes
Jan 25, 2023
fnesveda
left a comment
Member
There was a problem hiding this comment.
Looks good! Just one suggestion for the not implemented methods.
Contributor
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
fnesveda
requested changes
Jan 25, 2023
fnesveda
left a comment
Member
There was a problem hiding this comment.
Looks good, just one last nitpick:
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
None of the pull request and linked issue has estimate
fnesveda
approved these changes
Jan 30, 2023
fnesveda
left a comment
Member
There was a problem hiding this comment.
Looks good now 👍, just the tests are failing probably because of a missing import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not much creative work mainly copy&pasting from python client.