fix: adjust tests of scrapy user data #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
If issue is not linked to the pull request then estimate the pull request!
vdusek
approved these changes
Oct 2, 2024
vdusek
reviewed
Oct 2, 2024
| @@ -25,7 +25,6 @@ def test__to_apify_request__simple(spider: Spider) -> None: | ||
| assert apify_request.url == 'https://example.com' | ||
|
|
||
| user_data = apify_request.user_data | ||
| assert isinstance(user_data, dict) |
There was a problem hiding this comment.
I don't get it why are we removing this? thanks
There was a problem hiding this comment.
UserData won't pass the check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs apify/crawlee-python#562