Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: Implement MemoryStorage and local storage clients #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jan 4, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
715b65e
feat: Implement MemoryStorage and local storage clients
jirimoravcik Dec 19, 2022
9db2a30
fix lint 1
jirimoravcik Dec 19, 2022
daa5d10
lint fix 2
jirimoravcik Dec 19, 2022
1294a08
Merge branch 'master' into feature/implement-memory-storage
jirimoravcik Dec 19, 2022
cb955ee
json dumps utility
jirimoravcik Dec 21, 2022
d15490c
fix lint
jirimoravcik Dec 21, 2022
2a3cc71
resolve todos, refactoring
jirimoravcik Dec 22, 2022
98d5c86
refactoring, fixes
jirimoravcik Dec 23, 2022
a22b835
Merge branch 'master' into feature/implement-memory-storage
jirimoravcik Dec 29, 2022
05378e4
Merge branch 'master' into feature/implement-memory-storage
jirimoravcik Dec 30, 2022
550b118
refactoring stuff, merging master
jirimoravcik Dec 30, 2022
cdeeea0
refactoring, docs
jirimoravcik Dec 30, 2022
bf744ba
Add unit tests for new utility methods
jirimoravcik Dec 30, 2022
f798e2b
fix format
jirimoravcik Dec 30, 2022
eb91c7f
revert MemoryStorage export
jirimoravcik Dec 30, 2022
ef91fd0
fixes and refactoring
jirimoravcik Jan 1, 2023
117a2d0
unit tests for memory storage
jirimoravcik Jan 1, 2023
db4fdc0
unit tests for collection clients
jirimoravcik Jan 1, 2023
a370f64
memory storage via an async fixture
jirimoravcik Jan 1, 2023
4cdfbd2
update timestamps private
jirimoravcik Jan 1, 2023
79e1140
Add unit tests for non-collection clients, add new configs with TODO,…
jirimoravcik Jan 2, 2023
d375c78
Merge branch 'master' into feature/implement-memory-storage
jirimoravcik Jan 3, 2023
a975048
address some PR comments
jirimoravcik Jan 3, 2023
b291a07
address PR comments
jirimoravcik Jan 4, 2023
b4f7a30
fix lint, align interface of MemoryStorage with python client one
jirimoravcik Jan 4, 2023
84fa371
fix types
jirimoravcik Jan 4, 2023
ebea14f
fix
jirimoravcik Jan 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
jirimoravcik committed Dec 21, 2022
commit d15490c2545bd2a71b075fbe6b8bbfecf4ae23de
4 changes: 3 additions & 1 deletion 4 src/apify/_utils.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import asyncio
import errno
import inspect
import json
import os
import sys
import time, json
import time
from datetime import datetime, timezone
from typing import Any, Callable, Dict, Generic, List, Optional, TypeVar, Union, cast

Expand Down Expand Up @@ -169,5 +170,6 @@ def _filter_out_none_values_recursively_internal(dictionary: Dict, remove_empty_
return None
return result


def _json_dumps(obj: Any) -> str:
return json.dumps(obj, ensure_ascii=False, indent=2, default=_json_serializer)
2 changes: 1 addition & 1 deletion 2 src/apify/memory_storage/resource_clients/request_queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ async def update_request(self, request: Dict, *, forefront: Optional[bool] = Non
existing_store_by_id.requests[request_model['id']] = request_model

handled_count_adjustment = 0
is_request_handled_state_changing = type(existing_request['orderNo']) != type(request_model['orderNo']) # noqa
is_request_handled_state_changing = type(existing_request['orderNo']) != type(request_model['orderNo']) # noqa
request_was_handled_before_update = existing_request['orderNo'] is None

if is_request_handled_state_changing:
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.