Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: Implement MemoryStorage and local storage clients #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jan 4, 2023
Merged

feat: Implement MemoryStorage and local storage clients #15

merged 27 commits into from
Jan 4, 2023

Conversation

jirimoravcik
Copy link
Member

@jirimoravcik jirimoravcik commented Dec 19, 2022 •
edited
Loading

There are some todos which are open for discussion. Feel free to ask whys and whats, give suggestions etc.
I know this is a huge PR, but it's better to see it as this whole package.

Also note points brought up in #3

@github-actions github-actions bot added this to the 53nd sprint - Platform team milestone Dec 19, 2022
@github-actions github-actions bot added the t-core-services Issues with this label are in the ownership of the platform team. label Dec 19, 2022
@jirimoravcik
fix lint 1
9db2a30
@jirimoravcik
lint fix 2
daa5d10
@jirimoravcik
Merge branch 'master' into feature/implement-memory-storage
1294a08
@jirimoravcik
json dumps utility
cb955ee
@jirimoravcik
fix lint
d15490c
@jirimoravcik
resolve todos, refactoring
2a3cc71
@jirimoravcik
refactoring, fixes
98d5c86
@jirimoravcik
Merge branch 'master' into feature/implement-memory-storage
a22b835
@jirimoravcik
Merge branch 'master' into feature/implement-memory-storage
05378e4
@jirimoravcik
refactoring stuff, merging master
550b118
@jirimoravcik
refactoring, docs
cdeeea0
@jirimoravcik
Add unit tests for new utility methods
bf744ba
@jirimoravcik
fix format
f798e2b
@jirimoravcik
revert MemoryStorage export
eb91c7f
@jirimoravcik
fixes and refactoring
ef91fd0
@jirimoravcik
unit tests for memory storage
117a2d0
@jirimoravcik
unit tests for collection clients
db4fdc0
@jirimoravcik
memory storage via an async fixture
a370f64
@jirimoravcik
update timestamps private
4cdfbd2
@jirimoravcik
Add unit tests for non-collection clients, add new configs with TODO,…
79e1140 
… fixes
@jirimoravcik jirimoravcik requested review from fnesveda, HonzaTuron and mhamas and removed request for mhamas and HonzaTuron January 2, 2023 08:40
fnesveda
fnesveda requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just had a few small comments, but overall I quite like it, and it's nicely tested.

.flake8 Outdated Show resolved Hide resolved
mypy.ini Outdated Show resolved Hide resolved
pytest.ini Outdated Show resolved Hide resolved
src/apify/_utils.py Outdated Show resolved Hide resolved
tests/unit/memory_storage/resource_clients/_common.py Outdated Show resolved Hide resolved
src/apify/memory_storage/memory_storage.py Outdated Show resolved Hide resolved
src/apify/memory_storage/memory_storage.py Outdated Show resolved Hide resolved
src/apify/memory_storage/memory_storage.py Show resolved Hide resolved
src/apify/memory_storage/resource_clients/dataset.py Outdated Show resolved Hide resolved
src/apify/memory_storage/resource_clients/key_value_store.py Outdated Show resolved Hide resolved
@jirimoravcik jirimoravcik requested a review from fnesveda January 4, 2023 12:44
fnesveda
fnesveda approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one last comment and then it's good to go 🙂

.flake8 Outdated Show resolved Hide resolved
@jirimoravcik jirimoravcik merged commit b7c9886 into master Jan 4, 2023
@jirimoravcik jirimoravcik deleted the feature/implement-memory-storage branch January 4, 2023 16:05
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels
t-core-services Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
53rd sprint - Platform team
Development

Successfully merging this pull request may close these issues.
2 participants
@jirimoravcik @fnesveda
Morty Proxy This is a proxified and sanitized view of the page, visit original site.