Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #7222] Bug fix and refactoring of the Indexfile in tiered storage#7224

Merged
lizhimins merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:fix-index-filelizhimins/rocketmq:fix-index-fileCopy head branch name to clipboard
Aug 23, 2023
Merged

[ISSUE #7222] Bug fix and refactoring of the Indexfile in tiered storage#7224
lizhimins merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:fix-index-filelizhimins/rocketmq:fix-index-fileCopy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #7222

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 22, 2023

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.56%. Comparing base (cc16a1b) to head (e04365d).
⚠️ Report is 655 commits behind head on develop.

Files with missing lines Patch % Lines
...che/rocketmq/tieredstore/file/TieredIndexFile.java 26.66% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7224      +/-   ##
=============================================
+ Coverage      42.44%   42.56%   +0.11%     
- Complexity      9344     9363      +19     
=============================================
  Files           1149     1149              
  Lines          82108    82121      +13     
  Branches       10702    10705       +3     
=============================================
+ Hits           34851    34955     +104     
+ Misses         42897    42785     -112     
- Partials        4360     4381      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 9bb73b9 into apache:develop Aug 23, 2023
@lizhimins lizhimins changed the title [#ISSUE 7222] Bug fix and refactoring of the Indexfile in tiered storage [ISSUE #7222] Bug fix and refactoring of the Indexfile in tiered storage Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Bug fix and refactoring of the Indexfile in tiered storage

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.