Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Bug] Bug fix and refactoring of the Indexfile in tiered storage #7222

Copy link
Copy link
@lizhimins

Description

@lizhimins
Issue body actions

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.
  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Linux 4.19

RocketMQ version

latest version in develop branch

JDK Version

JDK11

Describe the Bug

The design logic of IndexFile in the current tiered storage system is confusion and there are some bugs, such as:

  • If the file that has been compacted is not successfully uploaded or still uploading, and the broker is restarted or crashes, the "current file" will not be initialized properly, resulting in the content of the file not being initialized to -1.
  • There are resource release issues, and the logic of resource release when compacting fails has not been considered.
  • The current design affects the main process of sending and receiving messages for building cq.
  • The current implementation of lock usage is incorrect.

Steps to Reproduce

None

What Did You Expect to See?

Resource not delete normally.

What Did You See Instead?

None

Additional Context

I will submit a bugfix for the current implementation and fix the ignored test cases. In the future, I hope to refactor the implementation of this IndexFile section.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.