PARQUET-196: parquet-tools command for row count & size#406
Closed
swapnilushinde wants to merge 2 commits intoapache:masterapache/parquet-java:masterfrom
Closed
PARQUET-196: parquet-tools command for row count & size#406swapnilushinde wants to merge 2 commits intoapache:masterapache/parquet-java:masterfrom
swapnilushinde wants to merge 2 commits intoapache:masterapache/parquet-java:masterfrom
Conversation
julienledem
approved these changes
Mar 2, 2017
Member
julienledem
left a comment
There was a problem hiding this comment.
Looks good to me.
Minor nit: fix spacing to conform to java style (in particular if/for/...)
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#15395
Contributor
Author
|
Thank you @julienledem. |
Contributor
Author
|
@julienledem I fixed spacing. Please check and merge if looks good. |
julienledem
approved these changes
Mar 27, 2017
Member
|
please update the title to start with "PARQUET-196: ..." (uppercase) to please the merge tool |
Contributor
Author
|
@julienledem Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase on already existing PR-
#132