PARQUET-2249: Add IEEE-754 total order and nan count for floating types#3393
Open
wgtmac wants to merge 1 commit intoapache:masterapache/parquet-java:masterfrom
Open
PARQUET-2249: Add IEEE-754 total order and nan count for floating types#3393wgtmac wants to merge 1 commit intoapache:masterapache/parquet-java:masterfrom
wgtmac wants to merge 1 commit intoapache:masterapache/parquet-java:masterfrom
Conversation
c01b3f3 to
4b7e86b
Compare
shangxinli
reviewed
Mar 15, 2026
shangxinli
reviewed
Mar 15, 2026
| mergeStatisticsMinMax(stats); | ||
| markAsNotEmpty(); | ||
| } | ||
| if (isNanCountSet() && stats.isNanCountSet()) { |
Contributor
There was a problem hiding this comment.
Minor: should we also validate that both stats have the same column order before merging? Merging IEEE 754 stats with TYPE_DEFINED_ORDER stats could produce incorrect min/max since NaN handling differs. Though type.equals() on line 408 may already cover this if column order is part of type equality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PoC implementation for the spec change: apache/parquet-format#514
What changes are included in this PR?
Are these changes tested?
Added various test cases for both new metadata and filtering.
Are there any user-facing changes?
Yes, users can now set the new column order but by default it is not used.
Closes #406