Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@laksh-krishna-sharma
Copy link
Contributor

What Does This PR Address?

Enhances the test_version_format() Error Message for Version Mismatches.

Fixes #949

Description

This PR enhances the test_version_format() function in tests/test_version.py by updating the error message to be more informative. The new message provides clearer guidance on resolving version mismatch issues, including a suggestion to rerun make install if needed.

@laksh-krishna-sharma
Copy link
Contributor Author

Sir I have resolved the issue carefully. Please review the updated.

@laksh-krishna-sharma laksh-krishna-sharma changed the title Improve test_version_format error message for version mismatches Improve test_version_format() error message for version mismatches Aug 2, 2024
tests/test_version.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

r? @sungwy

@laksh-krishna-sharma
Copy link
Contributor Author

Thank you for your feedback, @kevinjqliu . I have resolved the issue carefully . Please review the updated.

@laksh-krishna-sharma
Copy link
Contributor Author

Sir, is there any new or further update?

@laksh-krishna-sharma
Copy link
Contributor Author

I will investigate the issue and address the failing tests as soon as possible. I'll update once the problem is resolved.

@kevinjqliu
Copy link
Contributor

Thanks @laksh-krishna-sharma
Looks like this is a linter issue

fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/test_version.py

You can run make lint to auto-correct

tests/test_version.py Outdated Show resolved Hide resolved
@laksh-krishna-sharma laksh-krishna-sharma deleted the feat/949-library-version-upgrade-fails-test-version-format branch August 7, 2024 12:32
@kevinjqliu
Copy link
Contributor

Closed in favor of #1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[documentation] library version upgrade fails test_version_format

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.