Improve test_version_format() error message for version mismatches #1015
Conversation
|
@kevinjqliu sir , Thanks for your feedback. I've resolved the linter issue as indicated. I created a new PR due to some issues on my machine. I apologize for any inconvenience this may have caused. Please review the updated changes. |
|
Looks like theres another lint issue. Can you run |
|
Sure, I'll run make lint again. |
|
|
|
can you try running I'm not very familiar with Windows environment |
|
Yes, I followed all the steps mentioned in the contribution guide and ran |
|
|
|
That's odd, it might be due to the specific Python version on Windows. I found a similar issue python-poetry/poetry#3894 (comment) |
|
Thanks for the contribution, @laksh-krishna-sharma |
|
Thank you, @kevinjqliu I am grateful for the opportunity to contribute and for your patient guidance. I would like to work more under your guidance in this repository. I am looking to contribute more and learn from you. This being my second contribution, it has been an amazing experience, and I have learned a lot. I am excited to continue contributing and learning. |
…pache#1015) * Update test_version_format to provide a clearer error message * Comment fix * Add newline * Update test_version_format to provide a clearer error message * linter fix --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
…pache#1015) * Update test_version_format to provide a clearer error message * Comment fix * Add newline * Update test_version_format to provide a clearer error message * linter fix --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
What Does This PR Address?
Enhances the test_version_format() Error Message for Version Mismatches.
Fixes #949
Description
This PR enhances the test_version_format() function in tests/test_version.py by updating the error message to be more informative. The new message provides clearer guidance on resolving version mismatch issues, including a suggestion to rerun make install if needed.