Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Set table properties with dictionary #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HonahX merged 2 commits into from
Mar 8, 2024
Merged

Set table properties with dictionary #503

HonahX merged 2 commits into from
Mar 8, 2024

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Mar 7, 2024 •
edited
Loading

Resolves #502

This PR modifies the Transactions set_properties API to allow passing table properties either as dictionary or as kwargs
For example,

with table.transaction() as transaction: 
    transaction.set_properties(abc="def")
    transaction.set_properties({"abc": "def"})

set_properties only allows table properties to be passed in either via dictionary or kwarg, not both. This removes complexity when both are set.

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/pass-properties-as-dict branch from 3e67fc9 to b2cd2e3 Compare March 7, 2024 04:27
This was referenced Mar 7, 2024
Merged
Closed
HonahX
HonahX approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kevinjqliu !

@HonahX HonahX merged commit ad40573 into apache:main Mar 8, 2024
@kevinjqliu kevinjqliu deleted the kevinjqliu/pass-properties-as-dict branch March 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HonahX HonahX HonahX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature request] easier API to set table properties

2 participants

@kevinjqliu @HonahX
Morty Proxy This is a proxified and sanitized view of the page, visit original site.