[#12196] fix(python): Deserialize datetime fields in AuditDTO#12197
Open
niraj-mx07 wants to merge 2 commits into
apache:mainapache/gravitino:mainfrom
niraj-mx07:fix-auditdto-datetimeniraj-mx07/gravitino:fix-auditdto-datetimeCopy head branch name to clipboard
Open
[#12196] fix(python): Deserialize datetime fields in AuditDTO#12197niraj-mx07 wants to merge 2 commits intoapache:mainapache/gravitino:mainfrom niraj-mx07:fix-auditdto-datetimeniraj-mx07/gravitino:fix-auditdto-datetimeCopy head branch name to clipboard
niraj-mx07 wants to merge 2 commits into
apache:mainapache/gravitino:mainfrom
niraj-mx07:fix-auditdto-datetimeniraj-mx07/gravitino:fix-auditdto-datetimeCopy head branch name to clipboard
Conversation
… violates Audit interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AuditDTOto usedatetimeinstead ofstrfor_create_timeand_last_modified_time.decoderandencoderfunctions indataclasses_jsonmetadata to properly parse the ISO-8601 strings intodatetimeobjects.create_time()andlast_modified_time()methods to properly returndatetime.datetimeobjects.Why are the changes needed?
The python client's
AuditDTOwas failing to deserializedatetimefields from JSON, keeping them as raw ISO-8601 strings (and marked withTODO: Can't deserialized datetime from JSON). This violated theAuditinterface, which definescreate_time()andlast_modified_time()to returndatetimeobjects. This change fixes the type mismatch at runtime.Fix: #12196
Does this PR introduce any user-facing change?
Yes,
AuditDTO.create_time()andAuditDTO.last_modified_time()in the Python client will now correctly returndatetimeobjects instead of strings, aligning with the expected interface.How was this patch tested?
test_relational_table.py,test_table_dto.py,test_responses.py) which now correctly assert againstdatetimeobjects.