Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Backport: kvm: truncate vnc password to 8 chars (#6244)#6402

Merged
nvazquez merged 2 commits intoapache:4.16apache/cloudstack:4.16from
shapeblue:backport6244shapeblue/cloudstack:backport6244Copy head branch name to clipboard
May 20, 2022
Merged

Backport: kvm: truncate vnc password to 8 chars (#6244)#6402
nvazquez merged 2 commits intoapache:4.16apache/cloudstack:4.16from
shapeblue:backport6244shapeblue/cloudstack:backport6244Copy head branch name to clipboard

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented May 20, 2022

Description

This PR backports #6244 to 4.16
(This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache @nvazquez
kvm: truncate vnc password to 8 chars (apache#6244)
99c69a4 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.
@nvazquez nvazquez added this to the 4.17.0.0 milestone May 20, 2022
NuxRo
NuxRo approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvazquez
Copy link
Contributor Author

nvazquez commented May 20, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 20, 2022

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez nvazquez mentioned this pull request May 20, 2022
Merged
12 tasks
weizhouapache
weizhouapache approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

blueorangutan commented May 20, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3455

@nvazquez
Copy link
Contributor Author

nvazquez commented May 20, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented May 20, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

slavkap
slavkap approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit 363a2cf into apache:4.16 May 20, 2022
@blueorangutan
Copy link

blueorangutan commented May 20, 2022

Trillian test result (tid-4219)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29818 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6402-t4219-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@leolleeooleo leolleeooleo mentioned this pull request May 21, 2022
Merged
5 tasks
@leolleeooleo
Copy link
Contributor

leolleeooleo commented May 21, 2022

This PR has an another issue when migrate VM which was started before update this PR.
image

I tried to edit xml (virsh edit i-12-68-VM), but it did not work.
It needs to stop VM and start again.
Is there any way to migrate without stopping the VM?

@nvazquez
Copy link
Contributor Author

nvazquez commented May 21, 2022

Hi @leolleeooleo are you able to reproduce after the fix? Not sure if possible without stopping the VM, but was wondering how did you manage to start the VM prior to this fix? Was the VM created prior upgrading libvirt maybe?

@leolleeooleo
Copy link
Contributor

leolleeooleo commented May 21, 2022

Hi @nvazquez
Yes, VM was created prior upgrading libvirt.
For example on two KVM host cluster.
Enable maintenance mode on the first KVM host. Update the system (dnf update), reboot, and disable maintenance mode.
Then it needs to migrate VM from the second KVM host to the first KVM host in order to update the second KVM host.
But the exception occur during migrate VM.

@nvazquez
Copy link
Contributor Author

nvazquez commented May 21, 2022

@leolleeooleo thanks for the explanation, let me explore if its possible to add a check for the VNC password length before the migration is executed

@nvazquez nvazquez mentioned this pull request May 22, 2022
Merged
12 tasks
@nvazquez
Copy link
Contributor Author

nvazquez commented May 22, 2022

Hi @leolleeooleo I have created this PR to fix the issue: #6404 could you please test it?

weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request May 24, 2022
@nvazquez @weizhouapache
Backport: kvm: truncate vnc password to 8 chars (apache#6244) (apache…
b247d40 
…#6402)

* kvm: truncate vnc password to 8 chars (apache#6244)

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* Use lang3 string utils

Co-authored-by: Wei Zhou <weizhou@apache.org>
@weizhouapache weizhouapache mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@NuxRo NuxRo NuxRo approved these changes

@slavkap slavkap slavkap approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@yadvr yadvr Awaiting requested review from yadvr

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:kvm type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nvazquez @blueorangutan @leolleeooleo @shwstppr @NuxRo @slavkap @weizhouapache
Morty Proxy This is a proxified and sanitized view of the page, visit original site.