Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

kvm: truncate vnc password to 8 chars#6244

Merged
yadvr merged 3 commits intoapache:mainapache/cloudstack:mainfrom
weizhouapache:4.16-kvm-truncate-vnc-password-8-charsweizhouapache/cloudstack:4.16-kvm-truncate-vnc-password-8-charsCopy head branch name to clipboard
Apr 15, 2022
Merged

kvm: truncate vnc password to 8 chars#6244
yadvr merged 3 commits intoapache:mainapache/cloudstack:mainfrom
weizhouapache:4.16-kvm-truncate-vnc-password-8-charsweizhouapache/cloudstack:4.16-kvm-truncate-vnc-password-8-charsCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Apr 11, 2022

Description

This PR truncates the vnc password of kvm vms to 8 chars.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Apr 11, 2022

this requires manually testing on ubuntu 22.04 or libvirt 8. I will not sure if novnc console works

@nvazquez
Copy link
Contributor

nvazquez commented Apr 12, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3132

@weizhouapache weizhouapache changed the base branch from 4.16 to main April 12, 2022 07:58
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Apr 12, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Apr 12, 2022

tested on centos7 and ubuntu20, vm console works.

I have not tested on ubuntu 22.04.

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3136

yadvr
yadvr reviewed Apr 12, 2022
View reviewed changes
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
}
if (_passwd != null) {
graphicBuilder.append(" passwd='" + _passwd + "'");
graphicBuilder.append(" passwd='" + StringUtils.truncate(_passwd, 8) + "'");
Copy link
Member

@yadvr yadvr Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that @weizhouapache ? Does this fix/address any libvirt limitation or user reported issue?

Copy link
Contributor Author

@weizhouapache weizhouapache Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohityadavcloud
this aims to fix an issue with ubuntu 22.04 (to be released soon) and libvirt 8.
the issue is raised in mailing list: https://lists.apache.org/thread/zk4fyggjqk1zphk4dfg1m596yrd15d9b

from many years ago, libvirt accepts vnc password with more than 8 chars. but only the first 8 chars in vnc password are used in vnc console verification (the other chars are dropped).
In recent libvirt, only vnc password with 8 chars is permitted.

Copy link
Member

@yadvr yadvr Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Apr 12, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3141

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Apr 12, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3143

@nvazquez
Copy link
Contributor

nvazquez commented Apr 12, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

Trillian Build Failed (tid-3871)

@nvazquez
Copy link
Contributor

nvazquez commented Apr 12, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 12, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 13, 2022

Trillian test result (tid-3879)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30158 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3879-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py

@nvazquez
Copy link
Contributor

nvazquez commented Apr 13, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 13, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 13, 2022

Trillian test result (tid-3884)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33260 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3884-kvm-centos7.zip
Smoke tests completed. 88 look OK, 5 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_primary_storage_disabled_host Error 0.56 test_primary_storage.py
test_01_primary_storage_nfs Error 0.10 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.19 test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster Failure 28.83 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 52.20 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 37.91 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 35.95 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 124.61 test_kubernetes_clusters.py
test_01_secure_vm_migration Error 149.24 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 274.11 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 143.78 test_vm_life_cycle.py
test_08_migrate_vm Error 43.78 test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store Error 8.43 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 8.43 test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance Error 305.93 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 9.27 test_hostha_kvm.py

@nvazquez
Copy link
Contributor

nvazquez commented Apr 13, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 13, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 13, 2022

Trillian test result (tid-3895)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32789 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3895-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache added this to the 4.17.0.0 milestone Apr 14, 2022
@weizhouapache weizhouapache marked this pull request as ready for review April 14, 2022 17:41
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Apr 14, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 14, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 14, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3176

@yadvr yadvr merged commit aa0197c into apache:main Apr 15, 2022
@weizhouapache weizhouapache mentioned this pull request Apr 22, 2022
Closed
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
0c55330 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

(cherry picked from commit aa0197c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
e1548c0 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

Backport of apache@aa0197c

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@weizhouapache weizhouapache mentioned this pull request May 18, 2022
Merged
5 tasks
yadvr added a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
3d420b9 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

Backport of apache@aa0197c

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
ebba6c5 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

(cherry picked from commit aa0197c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
39f72af 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

(cherry picked from commit aa0197c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
c375bde 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

(cherry picked from commit aa0197c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
945d443 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

(cherry picked from commit aa0197c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
kvm: truncate vnc password to 8 chars (apache#6244)
b86214b 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

(cherry picked from commit aa0197c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
nvazquez pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022
@weizhouapache @nvazquez
kvm: truncate vnc password to 8 chars (apache#6244)
99c69a4 
This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.
@nvazquez nvazquez mentioned this pull request May 20, 2022
Merged
12 tasks
nvazquez added a commit that referenced this pull request May 20, 2022
@nvazquez @weizhouapache
Backport: kvm: truncate vnc password to 8 chars (#6244) (#6402)
363a2cf 
* kvm: truncate vnc password to 8 chars (#6244)

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* Use lang3 string utils

Co-authored-by: Wei Zhou <weizhou@apache.org>
weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request May 24, 2022
@nvazquez @weizhouapache
Backport: kvm: truncate vnc password to 8 chars (apache#6244) (apache…
b247d40 
…#6402)

* kvm: truncate vnc password to 8 chars (apache#6244)

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* Use lang3 string utils

Co-authored-by: Wei Zhou <weizhou@apache.org>
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Sep 6, 2022
@shwstppr @slavkap
@weizhouapache @nvazquez
el8 fixes backport (apache#155)
de14141 
* Extract the IO_URING configuration into the agent.properties (apache#6253)

When using advanced virtualization the IO Driver is not supported. The
admin will decide if want to enable/disable this configuration from
agent.properties file. The default value is true

* kvm: truncate vnc password to 8 chars (apache#6244)

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* merge fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* [KVM] Enable IOURING only when it is available on the host (apache#6399)

* [KVM] Disable IOURING by default on agents

* Refactor

* Remove agent property for iouring

* Restore property

* Refactor suse check and enable on ubuntu by default

* Refactor irrespective of guest OS

* Improvement

* Logs and new path

* Refactor condition to enable iouring

* Improve condition

* Refactor property check

* Improvement

* Doc comment

* Extend comment

* Move method

* Add log

* [KVM] Fix VM migration error due to VNC password on libvirt limiting versions (apache#6404)

* [KVM] Fix VM migration error due to VNC password on libvirt limiting versions

* Fix passwd value

* Simplify implementation

Co-authored-by: slavkap <51903378+slavkap@users.noreply.github.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com>
@weizhouapache weizhouapache deleted the 4.16-kvm-truncate-vnc-password-8-chars branch December 9, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees

No one assigned

Labels

component:kvm

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @nvazquez @blueorangutan @yadvr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.