Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Handle incomplete HTTP redirects missing LOCATION (#2795) - #2796

#2796
Merged
tustvold merged 1 commit into
apache:masterapache/arrow-rs:masterfrom
tustvold:handle-incomplete-redirectstustvold/arrow-rs:handle-incomplete-redirectsCopy head branch name to clipboard
Sep 29, 2022
Merged

Handle incomplete HTTP redirects missing LOCATION (#2795)#2796
tustvold merged 1 commit into
apache:masterapache/arrow-rs:masterfrom
tustvold:handle-incomplete-redirectstustvold/arrow-rs:handle-incomplete-redirectsCopy head branch name to clipboard

Conversation

@tustvold

@tustvold tustvold commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes apache/arrow-rs-object-store#224

Rationale for this change

S3 does strange things, see aws/aws-sdk-go#356

What changes are included in this PR?

Are there any user-facing changes?

@tustvold
tustvold force-pushed the handle-incomplete-redirects branch from f5af6bb to 0d2b32f Compare September 28, 2022 09:38
andygrove
andygrove approved these changes Sep 29, 2022
View reviewed changes

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I have not yet tested this

@tustvold
tustvold merged commit f845d6e into apache:master Sep 29, 2022
@ursabot

ursabot commented Sep 29, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 178319b and contender = f845d6e. f845d6e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Sep 30, 2022
Closed
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Mar 20, 2025
@tustvold
Handle incomplete HTTP redirects missing LOCATION (#2795) (apache#2796)
8ad0a18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Erratic Behaviour if Incorrect S3 Region Configured

3 participants

@tustvold @ursabot @andygrove
Morty Proxy This is a proxified and sanitized view of the page, visit original site.