GH-50627: [C++] Migrate from_string.cc to simdjson#50644
GH-50627: [C++] Migrate from_string.cc to simdjson#50644KHARSHAVARDHAN-eng wants to merge 1 commit intoapache:mainapache/arrow:mainfrom KHARSHAVARDHAN-eng:gh-50627-migrate-from-string-to-simdjsonKHARSHAVARDHAN-eng/arrow:gh-50627-migrate-from-string-to-simdjsonCopy head branch name to clipboard
Conversation
|
|
There was a problem hiding this comment.
Before I review this PR.. I think this change belongs to another PR, could you verify and remove this file.
Reranko05
left a comment
There was a problem hiding this comment.
Can you run python -m pre_commit run clang-format --files cpp/src/arrow/json/from_string.cc to fix the formatting issues?
Reranko05
left a comment
There was a problem hiding this comment.
I noticed this migration uses the simdjson::dom API. In my earlier migration work on ObjectParser, I was suggested to use the ondemand API instead of dom. Should we use ondemand here as well, or is there a reason dom is preferred in this case? @kou, what do you think?
e9ec2e6 to
d4ed946
Compare
|
Thanks for pointing this out! The branch originally started from another feature branch, which accidentally included an unrelated commit. I've rebased the branch onto |
|
Done, thanks! I've run the project's |
|
Thanks! Let's wait for @kou to weigh in on the |
Rationale for this change
This PR continues the migration from RapidJSON to simdjson as part of GH-35460 by migrating the JSON parsing implementation in
cpp/src/arrow/json/from_string.ccto usesimdjson::dom.What changes are included?
simdjson::dom::parserandsimdjson::dom::element.from_string.cc.simdjson::dom::element.simdjson::dom.NaN/Infand raw non-UTF-8 binary strings) to preserve the behavior exercised by the existingfrom_stringtest suite.Testing
Verified with:
Output:
User-facing changes
None.
This change does not modify the public API or user-visible behavior.
Closes #50627.
simdjsoninfrom_string.ccand tests #50627