Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

I've noticed that in FileMetaDataBuilderImpl::Finish() there is a copy of row_groups_ field done by passing it via const& to metadata_->__set_row_groups(row_groups_). However, if it is assumed that after calling the Finish() method nothing should be touching the row_groups_ field anymore then maybe it could be moved instead?

You must be logged in to vote

In my opinion this makes sense, do you want to open an issue and submit a PR?

Replies: 1 comment · 1 reply

Comment options

In my opinion this makes sense, do you want to open an issue and submit a PR?

You must be logged in to vote
1 reply
@kostrzewa9ld
Comment options

Sure, I will give it a try in a few days.

Answer selected by kostrzewa9ld
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
🙏
Q&A
Labels
None yet
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.