fix:chown socket file to belong to nobody#54
Open
zar3bski wants to merge 3 commits into
apache:masterapache/apisix-python-plugin-runner:masterfrom
zar3bski:fix_issue_53zar3bski/apisix-python-plugin-runner:fix_issue_53Copy head branch name to clipboard
Open
fix:chown socket file to belong to nobody#54zar3bski wants to merge 3 commits intoapache:masterapache/apisix-python-plugin-runner:masterfrom zar3bski:fix_issue_53zar3bski/apisix-python-plugin-runner:fix_issue_53Copy head branch name to clipboard
zar3bski wants to merge 3 commits into
apache:masterapache/apisix-python-plugin-runner:masterfrom
zar3bski:fix_issue_53zar3bski/apisix-python-plugin-runner:fix_issue_53Copy head branch name to clipboard
Conversation
spacewander
reviewed
Sep 16, 2022
Author
|
@spacewander , @shuaijinchao , could you review this MR please? |
Author
|
@spacewander @shuaijinchao Plz give me a approval :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to solve this bug, the socket created by apisix/runner/server/server.py now belongs to
nobodyso apisix runners could write on it.I choose not to follow go plugin's
chmodapproach here, for it is to permissive / dangerous and could lead to privilege escalation