Align Trigger DAG params in grid layout#67905
Align Trigger DAG params in grid layout#67905Codingaditya17 wants to merge 1 commit intoapache:mainapache/airflow:mainfrom Codingaditya17:fix-trigger-dag-param-grid-layoutCodingaditya17/airflow:fix-trigger-dag-param-grid-layoutCopy head branch name to clipboard
Conversation
01d0089 to
92b73b8
Compare
92b73b8 to
3469c7b
Compare
Abdeltoto
left a comment
There was a problem hiding this comment.
Looks good to me. The change is nicely scoped to FieldRow, keeps the validation/helper/error rendering intact, and addresses the alignment problem described in #67852. CI is green.
Non-blocking: the Tested with code block in the PR description looks like it may be missing its closing backticks.
|
Thanks for the review and approval! I updated the PR description to close the |
|
Hi @Codingaditya17 , thank you for your work! I would keep in mind these incoming changes #67859 |
pierrejeambrun
left a comment
There was a problem hiding this comment.
This is what I'm getting currently on main with your change in it:
It doesn't look right.
PLease add before/after screenshots when working on UI contribution (as per our contribution guide)
|
Closing in favor of #67859 that is ready to be merged. |
Closes: #67852
This updates the FlexibleForm field row layout to use a responsive two-column grid.
The label is rendered in the left column and the field control is rendered in a dedicated right column, which keeps boolean switches and other controls aligned consistently across params with different label lengths.
Long labels are allowed to wrap safely with
overflowWrap="anywhere"and the layout falls back to a single column on smaller screens.Tested with:
cd airflow-core/src/airflow/ui PNPM_IGNORE_SCRIPTS=true pnpm lint