Fix catalog mock refactor 2 - #4
#4Open
anup39 wants to merge 17 commits into
fix_catalog_mock_refactoranup39/MapStore2:fix_catalog_mock_refactorfrom
fix_catalog_mock_refactor_2anup39/MapStore2:fix_catalog_mock_refactor_2Copy head branch name to clipboard
Open
Fix catalog mock refactor 2#4anup39 wants to merge 17 commits intofix_catalog_mock_refactoranup39/MapStore2:fix_catalog_mock_refactorfrom fix_catalog_mock_refactor_2anup39/MapStore2:fix_catalog_mock_refactor_2Copy head branch name to clipboard
anup39 wants to merge 17 commits into
fix_catalog_mock_refactoranup39/MapStore2:fix_catalog_mock_refactorfrom
fix_catalog_mock_refactor_2anup39/MapStore2:fix_catalog_mock_refactor_2Copy head branch name to clipboard
Conversation
- Support for filtrex syntax for rules - removed scalebox template for display property - minor improvements and cleanup
…get tray (geosolutions-it#11964) * Fix the button style issue in filter widget and widget tray * Update the css * Update the css to make it generic for all the button groups
…or in CRS Selector (geosolutions-it#12030) * Fix: geosolutions-it#12029 Long CRS name overflows in dropdown selector in CRS selector plugin * fix maxwidth to allow display of long CRS name * Added width to fit the content for crs name with min width of 4 rem
* fix(Dockerfile): change user of MapStore image * fix(Dockerfile): update user of MapStore image
…x_catalog_mock_refactor
| selectedFormat={selectedFormat} | ||
| onSortChange={onSortChange} | ||
| sort={sort} | ||
| {...props} |
There was a problem hiding this comment.
please write the props we are passing instead of ...props
| layers={layers} | ||
| currentLocale={currentLocale} | ||
| readOnly={readOnly} | ||
| {...props} |
There was a problem hiding this comment.
please write the props we are passing instead of ...props
| ? { | ||
| ...dockStyle, | ||
| display: active ? 'block' : 'none' | ||
| ...panelStyle, |
| const [result, setResult] = useState(''); | ||
| const [searchOptions] = useState({}); | ||
| const [layerOptions] = useState({}); | ||
| const locales = 'en-US'; |
There was a problem hiding this comment.
transform this as prop default with en-US
Comment on lines
+58
to
+61
| if (onSelect) { | ||
| onSelect({ record }, checked, event); | ||
| } else { | ||
| onRecordSelected(record); |
There was a problem hiding this comment.
Here we should have just the onSelect
| @@ -101,6 +101,8 @@ export default connect((state) =>({ | ||
| onRecordSelected={r => setSelected(r)} | ||
| getItems={getItems} |
| onRecordSelected={r => setSelected(r)} | ||
| getItems={getItems} | ||
| onItemClick={onItemClick} | ||
| onSelect={onItemClick} |
| includeAddToMap={false} | ||
| onChangeCatalogMode={onChangeCatalogMode} | ||
| selectedService={dashboardSelectedService === "" ? dashboardSelectedService : dashboardSelectedService === undefined ? defaultSelectedService : dashboardSelectedService} | ||
| onChangeSelectedService={(service) => onChangeSelectedService(service, dashboardServices || defaultServices)} services={ dashboardServices || defaultServices} selected={selected} catalog={catalog} onRecordSelected={r => setSelected(r)} |
There was a problem hiding this comment.
just replace onRecordSelected with onSelect and review the expected behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information