Fix edge pair validation for hyphenated node names#309
Open
chaochaoweb3 wants to merge 2 commits into
antvis:mainantvis/mcp-server-chart:mainfrom
chaochaoweb3:codex/fix-edge-pair-validationchaochaoweb3/mcp-server-chart:codex/fix-edge-pair-validationCopy head branch name to clipboard
Open
Fix edge pair validation for hyphenated node names#309chaochaoweb3 wants to merge 2 commits intoantvis:mainantvis/mcp-server-chart:mainfrom chaochaoweb3:codex/fix-edge-pair-validationchaochaoweb3/mcp-server-chart:codex/fix-edge-pair-validationCopy head branch name to clipboard
chaochaoweb3 wants to merge 2 commits into
antvis:mainantvis/mcp-server-chart:mainfrom
chaochaoweb3:codex/fix-edge-pair-validationchaochaoweb3/mcp-server-chart:codex/fix-edge-pair-validationCopy head branch name to clipboard
Conversation
chaochaoweb3
marked this pull request as ready for review
June 3, 2026 08:13
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the node-edge validator to correctly distinguish edge pairs when node names contain hyphens, replacing the hyphen-delimited string key with a JSON-stringified array and adding a test case. The reviewer suggests optimizing this by using a null character (\0) delimiter instead of JSON.stringify to avoid unnecessary CPU and memory overhead in the loop.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The validator currently builds edge uniqueness keys with
${source}-${target}. This collides for different edge pairs when node names themselves contain hyphens, for examplea-b -> canda -> b-cboth becomea-b-c. Those valid inputs are rejected as duplicate edges.Validation
npm test -- --run __tests__/utils/validator.spec.ts(3 passed)npm test -- --run(44 passed)npm run buildnpx biome check __tests__/utils/validator.spec.ts src/utils/validator.tsgit diff --check