Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(material-experimental/checkbox): Add test harnesses for both versions of mat-checkbox#16334

Merged
jelbourn merged 8 commits into
angular:masterangular/components:masterfrom
mmalerba:harness-cbmmalerba/components:harness-cbCopy head branch name to clipboard
Jun 21, 2019
Merged

feat(material-experimental/checkbox): Add test harnesses for both versions of mat-checkbox#16334
jelbourn merged 8 commits into
angular:masterangular/components:masterfrom
mmalerba:harness-cbmmalerba/components:harness-cbCopy head branch name to clipboard

Conversation

@mmalerba

Copy link
Copy Markdown
Contributor

No description provided.

@mmalerba mmalerba requested review from crisbeto and jelbourn June 19, 2019 21:10
@mmalerba mmalerba requested a review from devversion as a code owner June 19, 2019 21:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 19, 2019

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/cdk-experimental/testing/protractor/protractor-element.ts
Comment thread src/material-experimental/mdc-checkbox/harness/checkbox-harness.ts Outdated
Comment thread src/material-experimental/mdc-checkbox/harness/checkbox-harness.ts
Comment thread src/material-experimental/mdc-checkbox/harness/checkbox-harness.ts Outdated
@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 20, 2019

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 21, 2019
@jelbourn jelbourn merged commit 7398c9a into angular:master Jun 21, 2019
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.