Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

perf(@angular-devkit/build-angular): reduce TypeScript JSDoc parsing in application builder #26463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Dec 8, 2023
Merged

perf(@angular-devkit/build-angular): reduce TypeScript JSDoc parsing in application builder #26463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions 6 packages/angular_devkit/build_angular/src/tools/esbuild/angular/angular-host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ export function createAngularCompilerHost(
): AngularCompilerHost {
// Create TypeScript compiler host
const host: AngularCompilerHost = ts.createIncrementalCompilerHost(compilerOptions);
// Set the parsing mode to the same as TS 5.3 default for tsc. This provides a parse
// performance improvement by skipping non-type related JSDoc parsing.
// NOTE: The check for this enum can be removed when TS 5.3 support is the minimum.
if (ts.JSDocParsingMode) {
host.jsDocParsingMode = ts.JSDocParsingMode.ParseForTypeErrors;
}

// The AOT compiler currently requires this hook to allow for a transformResource hook.
// Once the AOT compiler allows only a transformResource hook, this can be reevaluated.
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.