perf(@angular-devkit/build-angular): reduce TypeScript JSDoc parsing in application builder#26463
Merged
clydin merged 1 commit intoangular:mainangular/angular-cli:mainfrom Dec 8, 2023
clydin:esbuild/jsdocparsemodeclydin/angular-cli:esbuild/jsdocparsemodeCopy head branch name to clipboard
Merged
perf(@angular-devkit/build-angular): reduce TypeScript JSDoc parsing in application builder#26463clydin merged 1 commit intoangular:mainangular/angular-cli:mainfrom clydin:esbuild/jsdocparsemodeclydin/angular-cli:esbuild/jsdocparsemodeCopy head branch name to clipboard
clydin merged 1 commit intoangular:mainangular/angular-cli:mainfrom
clydin:esbuild/jsdocparsemodeclydin/angular-cli:esbuild/jsdocparsemodeCopy head branch name to clipboard
Conversation
f6358db to
980acd4
Compare
…in application builder TypeScript 5.3 provides a new programmatically accessible option on the compiler host object to control the amount of JSDoc parsing that the TypeScript parser will perform. The `tsc` command line tool now uses the `ParseForTypeErrors` value which only parses JSDoc comments that may affect type checking and is considered a good default for tools such as the Angular CLI. The Angular CLI will now attempt to use the `ParseForTypeErrors` value as well when available. Projects will need to use TypeScript 5.3+ for this option to be available. No behavior changes will occur on TypeScript 5.2 projects. This should not only provide a small improvement to build times but also a reduction in overall memory usage.
980acd4 to
37ee033
Compare
alan-agius4
approved these changes
Dec 8, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 5.3 provides a new programmatically accessible option on the compiler host object to control the amount of JSDoc parsing that the TypeScript parser will perform. The
tsccommand line tool now uses theParseForTypeErrorsvalue which only parses JSDoc comments that may affect type checking and is considered a good default for tools such as the Angular CLI. The Angular CLI will now attempt to use theParseForTypeErrorsvalue as well when available. Projects will need to use TypeScript 5.3+ for this option to be available. No behavior changes will occur on TypeScript 5.2 projects. This should not only provide a small improvement to build times but also a reduction in overall memory usage.