Respect cache directives and avoid request deduplication for unhashed assets#69302
Open
SkyZeroZx wants to merge 2 commits into
angular:mainangular/angular:mainfrom
SkyZeroZx:fix-sw/here-we-are-againSkyZeroZx/angular:fix-sw/here-we-are-againCopy head branch name to clipboard
Open
Respect cache directives and avoid request deduplication for unhashed assets#69302SkyZeroZx wants to merge 2 commits intoangular:mainangular/angular:mainfrom SkyZeroZx:fix-sw/here-we-are-againSkyZeroZx/angular:fix-sw/here-we-are-againCopy head branch name to clipboard
SkyZeroZx wants to merge 2 commits into
angular:mainangular/angular:mainfrom
SkyZeroZx:fix-sw/here-we-are-againSkyZeroZx/angular:fix-sw/here-we-are-againCopy head branch name to clipboard
Conversation
Respect Cache-Control directives for unhashed asset resources and skip CacheStorage writes for responses marked no-store or private. Evict existing unsafe cached entries before fetching from the network.
Limit URL-based in-flight request deduplication to hashed asset resources. Unhashed runtime resources may vary by session, so concurrent requests should fetch independently.
1213038 to
c926c9d
Compare
SkyZeroZx
commented
Jun 11, 2026
|
|
||
| const UNCACHEABLE_CACHE_CONTROL_DIRECTIVES = new Set(['no-store', 'private', 'no-cache']); | ||
|
|
||
| function hasUncacheableCacheControl(headers: Headers): boolean { |
Contributor
Author
There was a problem hiding this comment.
This is similar to how we now handle no-cache responses in HttpTransferCache
#69017
Contributor
Author
|
Sorry to bother you @JeanMeche and @alan-agius4 You could review this PR as it's a similar issue we've had in TransferCache (Or so I think) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(service-worker): avoid caching private unhashed assets
Respect Cache-Control directives for unhashed asset resources and skip CacheStorage writes for responses marked no-store or private. Evict existing unsafe cached entries before fetching from the network.
More context https://issuetracker.google.com/u/1/issues/522520490
fix(service-worker): deduplicate only hashed asset fetches
Limit URL-based in-flight request deduplication to hashed asset resources. Unhashed runtime resources may vary by session, so concurrent requests should fetch independently.