[backport 19.2.X] skip transfer cache for uncacheable HTTP headers#69094
Closed
SkyZeroZx wants to merge 1 commit into
angular:19.2.xangular/angular:19.2.xfrom
SkyZeroZx:fix/trasnfercache-19SkyZeroZx/angular:fix/trasnfercache-19Copy head branch name to clipboard
Closed
[backport 19.2.X] skip transfer cache for uncacheable HTTP headers#69094SkyZeroZx wants to merge 1 commit intoangular:19.2.xangular/angular:19.2.xfrom SkyZeroZx:fix/trasnfercache-19SkyZeroZx/angular:fix/trasnfercache-19Copy head branch name to clipboard
SkyZeroZx wants to merge 1 commit into
angular:19.2.xangular/angular:19.2.xfrom
SkyZeroZx:fix/trasnfercache-19SkyZeroZx/angular:fix/trasnfercache-19Copy head branch name to clipboard
Conversation
Do not store HTTP transfer cache entries when either the request or response uses `Cache-Control: no-store`, `Cache-Control: private`, or `Cache-Control: no-cache`. Because transfer cache serializes SSR HTTP responses into the rendered HTML, Angular now treats these directives conservatively to avoid exposing sensitive or explicitly uncacheable data through `TransferState`.
7f8e0ec to
07857b8
Compare
Member
|
We won't be backporting it to 19.2 as it will be outside of LTS when #69017 gets merged. We will need a PR targeting the v21 branch specificaly though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #69017
Only the uncacheable headers commit is backported, since in Angular 19, the Fetch API still does not support credentials or caching.