fix(platform-server): normalize path parsing in ServerPlatformLocation#68930
Merged
alxhub merged 1 commit intoMay 27, 2026
angular:20.3.xangular/angular:20.3.xfrom
alan-agius4:backport-68928-20.3.xalan-agius4/angular:backport-68928-20.3.xCopy head branch name to clipboard
Merged
fix(platform-server): normalize path parsing in ServerPlatformLocation#68930alxhub merged 1 commit intoangular:20.3.xangular/angular:20.3.xfrom alan-agius4:backport-68928-20.3.xalan-agius4/angular:backport-68928-20.3.xCopy head branch name to clipboard
alxhub merged 1 commit into
angular:20.3.xangular/angular:20.3.xfrom
alan-agius4:backport-68928-20.3.xalan-agius4/angular:backport-68928-20.3.xCopy head branch name to clipboard
Conversation
AndrewKushnir
approved these changes
May 26, 2026
6579fcf to
cf08b2a
Compare
…inst SSRF and path hijack Normalizes the URL and path parsing logic inside platform-server by consolidating security checks and normalizations into a single, unified parseUrl helper function. This includes: - Collapsing multiple consecutive leading slashes and backslashes (e.g., // or /\) to a single forward slash to avoid protocol-relative parsing of path-like & relative inputs. - Rejecting malformed absolute URLs that are otherwise accepted by lenient DOM parsers like Domino but rejected by standard WHATWG parsers, preventing SSRF / allowedHosts validation bypasses. - Ensuring parseDocument gets the fully parsed and normalized URL instead of raw, unvalidated configuration values, preventing virtual document hostname adoption/origin hijack. - Moving parseUrl unit tests into a dedicated url_spec.ts test file to keep platform_location_spec.ts clean and decoupled.
cf08b2a to
099af33
Compare
AndrewKushnir
approved these changes
May 27, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizes request path parsing in ServerPlatformLocation by collapsing multiple consecutive leading slashes and backslashes (e.g. // or /) down to a single forward slash. This ensures consistent resolution of relative path segments and prevents unexpected absolute path overrides during URL parsing.