Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(service-worker): preserve redirect policy on reconstructed asset requests#68876

Merged
alxhub merged 2 commits into
angular:20.3.xangular/angular:20.3.xfrom
alan-agius4:sw-fix-backportalan-agius4/angular:sw-fix-backportCopy head branch name to clipboard
May 27, 2026
Merged

fix(service-worker): preserve redirect policy on reconstructed asset requests#68876
alxhub merged 2 commits into
angular:20.3.xangular/angular:20.3.xfrom
alan-agius4:sw-fix-backportalan-agius4/angular:sw-fix-backportCopy head branch name to clipboard

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

No description provided.

Yenya030 added 2 commits May 22, 2026 07:32
…requests

Preserve the redirect mode when rebuilding asset requests in newRequestWithMetadata(). This keeps explicit redirect:error semantics intact across service-worker redirect handling.

Update the worker test mocks to model redirect defaults correctly and add focused regression coverage for redirected lazy assets with redirect:error.
Use the typed Response.redirected property directly in the service-worker test mock instead of casting to any.
@alan-agius4 alan-agius4 added the target: lts This PR is targeting a version currently in long-term support label May 22, 2026
@pullapprove pullapprove Bot requested a review from kirjs May 22, 2026 07:35
@angular-robot angular-robot Bot added the area: service-worker Issues related to the @angular/service-worker package label May 22, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 22, 2026
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 22, 2026
@alan-agius4 alan-agius4 requested review from JeanMeche and removed request for kirjs May 22, 2026 07:36
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2026
@alan-agius4

Copy link
Copy Markdown
Contributor Author

caretaker note: ignore the pending mergeability status since this is LTS.

@alxhub alxhub merged commit 9b5f8c2 into angular:20.3.x May 27, 2026
24 of 26 checks passed
@alxhub

alxhub commented May 27, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.