Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(compiler-cli): rename flag for enabling fast type declaration emission #61353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

jonathan-meier
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Enabling fast type declaration emission is controlled by the flag _geminiAllowEmitDeclarationOnly.

What is the new behavior?

Renamed the flag _geminiAllowEmitDeclarationOnly to _experimentalAllowEmitDeclarationOnly as a follow-up on a comment in PR #61334.

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from JoostK May 14, 2025 22:53
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label May 14, 2025
@ngbot ngbot bot added this to the Backlog milestone May 14, 2025
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release action: presubmit The PR is in need of a google3 presubmit labels May 14, 2025
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 16, 2025
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented May 16, 2025

Caretaker note: presubmit is "green".

// FYI, pushed a rebase to restart the CI (it didn't start automatically for some reasons).

…ssion

Rename the flag `_geminiAllowEmitDeclarationOnly` to
`_experimentalAllowEmitDeclarationOnly` as a follow-up on a comment in
PR angular#61334.
@AndrewKushnir AndrewKushnir force-pushed the fix_experimental_allow_declaration_only_flag_name_b416702881 branch from a6c962b to 0e9689d Compare May 16, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: presubmit The PR is in need of a google3 presubmit area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.