Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a6c962b

Browse filesBrowse files
author
Jonathan Meier
committed
fix(compiler-cli): rename flag for enabling fast type declaration emission
Rename the flag `_geminiAllowEmitDeclarationOnly` to `_experimentalAllowEmitDeclarationOnly` as a follow-up on a comment in PR #61334.
1 parent e62fb35 commit a6c962b
Copy full SHA for a6c962b

File tree

5 files changed

+6
-6
lines changed
Filter options

5 files changed

+6
-6
lines changed

‎goldens/public-api/compiler-cli/compiler_options.api.md

Copy file name to clipboardExpand all lines: goldens/public-api/compiler-cli/compiler_options.api.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
// @public
88
export interface BazelAndG3Options {
99
annotateForClosureCompiler?: boolean;
10-
_geminiAllowEmitDeclarationOnly?: boolean;
10+
_experimentalAllowEmitDeclarationOnly?: boolean;
1111
generateDeepReexports?: boolean;
1212
generateExtraImportsInLocalMode?: boolean;
1313
onlyExplicitDeferDependencyImports?: boolean;

‎packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts

Copy file name to clipboardExpand all lines: packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,9 +353,9 @@ export interface BazelAndG3Options {
353353
* references.
354354
*
355355
* The mode is experimental and specifically tailored to support fast type declaration emission
356-
* for the Gemini app in g3.
356+
* for the Gemini app in g3 for the initial phase of the experiment.
357357
*/
358-
_geminiAllowEmitDeclarationOnly?: boolean;
358+
_experimentalAllowEmitDeclarationOnly?: boolean;
359359
}
360360

361361
/**

‎packages/compiler-cli/src/ngtsc/core/src/compiler.ts

Copy file name to clipboardExpand all lines: packages/compiler-cli/src/ngtsc/core/src/compiler.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ export class NgCompiler {
468468
this.enableLetSyntax = options['_enableLetSyntax'] ?? true;
469469
this.enableSelectorless = options['_enableSelectorless'] ?? false;
470470
this.emitDeclarationOnly =
471-
!!options.emitDeclarationOnly && !!options._geminiAllowEmitDeclarationOnly;
471+
!!options.emitDeclarationOnly && !!options._experimentalAllowEmitDeclarationOnly;
472472
// Standalone by default is enabled since v19. We need to toggle it here,
473473
// because the language service extension may be running with the latest
474474
// version of the compiler against an older version of Angular.

‎packages/compiler-cli/test/compliance/declaration-only/declaration_only_emit_spec.ts

Copy file name to clipboardExpand all lines: packages/compiler-cli/test/compliance/declaration-only/declaration_only_emit_spec.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function emitDeclarationOnlyTest(fs: FileSystem, test: ComplianceTest): CompileR
4343
},
4444
{
4545
...test.angularCompilerOptions,
46-
_geminiAllowEmitDeclarationOnly: true,
46+
_experimentalAllowEmitDeclarationOnly: true,
4747
},
4848
);
4949
}

‎packages/compiler-cli/test/ngtsc/declaration_only_emission_spec.ts

Copy file name to clipboardExpand all lines: packages/compiler-cli/test/ngtsc/declaration_only_emission_spec.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ runInEachFileSystem(() => {
3131
noCheck: true,
3232
},
3333
angularCompilerOptions: {
34-
_geminiAllowEmitDeclarationOnly: true,
34+
_experimentalAllowEmitDeclarationOnly: true,
3535
},
3636
};
3737
env.write('tsconfig.json', JSON.stringify(tsconfig, null, 2));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.