fix(forms): Don't send updates for identical input values #55761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0db415b to
efada8d
Compare
In case an input event sends the same value to our forms, we will discard the update and consider the input hasn't change. This will prevent having duplicate values on the valueChanges event. Fixes angular#43228
efada8d to
2c6cd7e
Compare
alxhub
approved these changes
Oct 17, 2024
|
In TGP (train): OCL:688303046:BASE:688537051:1729617073387:be2fcd5 |
|
As expected, TGP revealed some breakages, though less than expected. The errors seem to indicate patterns where identical (===) objects are passed but have deep mutations. Dropping this from v19 for now and will follow up with @JeanMeche. |
|
I'll close it as this is probably too breaking. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an input event sends the same value to our forms, we will discard the update and consider the input hasn't change. This will prevent having duplicate values on the valueChanges event.
Fixes #43228
Note: Seing how this change broke our tests, I have low confidence we'll be able to merge it.