fix(forms): Multiple formControlName directives using the same FormControl do not stay in sync #53668
Conversation
5b832d4 to
70061ea
Compare
| * @private | ||
| */ | ||
| private _syncControlValuesUnderSameFormGroup(newValue: any): void { | ||
| if (this._parent instanceof FormGroupDirective) { |
There was a problem hiding this comment.
We might also want to supporte the FormArrayDirective here
There was a problem hiding this comment.
took in account
| private _syncControlValuesUnderSameFormGroup(newValue: any): void { | ||
| if (this._parent instanceof FormGroupDirective) { | ||
| this._parent.directives.forEach((dir: FormControlName) => { | ||
| const sameControlReference = dir!.control === this.control; |
There was a problem hiding this comment.
It looks like the non null assertion isn't necessary here.
There was a problem hiding this comment.
took in account
…ntrol do not stay in sync When other controls share the same form control reference Fixes angular#51239
70061ea to
1ba8543
Compare
|
I agree in principle that this would be a nice fix, but it's certain to be a significant breaking change (as is frequently the case with Forms changes). I could run a Google global presubmit to find out how bad the breakage is though. |
Is there any news on this? We're currently trying to refactor a part of our application that would require this fix. Nothing really pressing, so no need to hurry here, but it would help us out tremendously! |
Fixes that currently binding the same `formControl` or `formControlName` to the same input doesn't keep the two in sync. Note that this was partially addressed in angular#53668, but it seems like that PR has stalled out and it only addresses `formControlName` and not `formControl`. Fixes angular#58300. Fixes angular#51239. Fixes angular#58522.
When other controls share the same form control reference
Fixes #50957