fix(core): reenable decorator downleveling for Angular npm packages#37317
Closed
IgorMinar wants to merge 1 commit into
angular:masterangular/angular:masterfrom
IgorMinar:build/reenable-tsickle-annotationsAsIgorMinar/angular:build/reenable-tsickle-annotationsAsCopy head branch name to clipboard
Closed
fix(core): reenable decorator downleveling for Angular npm packages#37317IgorMinar wants to merge 1 commit intoangular:masterangular/angular:masterfrom IgorMinar:build/reenable-tsickle-annotationsAsIgorMinar/angular:build/reenable-tsickle-annotationsAsCopy head branch name to clipboard
IgorMinar wants to merge 1 commit into
angular:masterangular/angular:masterfrom
IgorMinar:build/reenable-tsickle-annotationsAsIgorMinar/angular:build/reenable-tsickle-annotationsAsCopy head branch name to clipboard
Conversation
|
You can preview b183949 at https://pr37317-b183949.ngbuilds.io/. |
b183949 to
c753b43
Compare
|
You can preview c753b43 at https://pr37317-c753b43.ngbuilds.io/. |
fd0e9f5 to
038c613
Compare
|
You can preview 038c613 at https://pr37317-038c613.ngbuilds.io/. |
|
You can preview f851487 at https://pr37317-f851487.ngbuilds.io/. |
kyliau
approved these changes
May 29, 2020
kara
approved these changes
May 29, 2020
kara
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
alxhub
approved these changes
May 29, 2020
In angular#37221 we disabled tsickle passes from transforming the tsc output that is used to publish all Angular framework and components packages (@angular/*). This change however revealed a bug in the ngc that caused __decorate and __metadata calls to still be emitted in the JS code even though we don't depend on them. Additionally it was these calls that caused code in @angular/material packages to fail at runtime due to circular dependency in the emitted decorator code documeted as microsoft/TypeScript#27519. This change partially rolls back angular#37221 by reenabling the decorator to static fields (static properties) downleveling. This is just a temporary workaround while we are also fixing root cause in `ngc` - tracked as FW-2199. Resolves FW-2198. Related to FW-2196
f851487 to
e56de29
Compare
|
You can preview e56de29 at https://pr37317-e56de29.ngbuilds.io/. |
matsko
pushed a commit
that referenced
this pull request
May 29, 2020
…37317) In #37221 we disabled tsickle passes from transforming the tsc output that is used to publish all Angular framework and components packages (@angular/*). This change however revealed a bug in the ngc that caused __decorate and __metadata calls to still be emitted in the JS code even though we don't depend on them. Additionally it was these calls that caused code in @angular/material packages to fail at runtime due to circular dependency in the emitted decorator code documeted as microsoft/TypeScript#27519. This change partially rolls back #37221 by reenabling the decorator to static fields (static properties) downleveling. This is just a temporary workaround while we are also fixing root cause in `ngc` - tracked as FW-2199. Resolves FW-2198. Related to FW-2196 PR Close #37317
Merged
14 tasks
14 tasks
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…ngular#37317) In angular#37221 we disabled tsickle passes from transforming the tsc output that is used to publish all Angular framework and components packages (@angular/*). This change however revealed a bug in the ngc that caused __decorate and __metadata calls to still be emitted in the JS code even though we don't depend on them. Additionally it was these calls that caused code in @angular/material packages to fail at runtime due to circular dependency in the emitted decorator code documeted as microsoft/TypeScript#27519. This change partially rolls back angular#37221 by reenabling the decorator to static fields (static properties) downleveling. This is just a temporary workaround while we are also fixing root cause in `ngc` - tracked as FW-2199. Resolves FW-2198. Related to FW-2196 PR Close angular#37317
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ngular#37317) In angular#37221 we disabled tsickle passes from transforming the tsc output that is used to publish all Angular framework and components packages (@angular/*). This change however revealed a bug in the ngc that caused __decorate and __metadata calls to still be emitted in the JS code even though we don't depend on them. Additionally it was these calls that caused code in @angular/material packages to fail at runtime due to circular dependency in the emitted decorator code documeted as microsoft/TypeScript#27519. This change partially rolls back angular#37221 by reenabling the decorator to static fields (static properties) downleveling. This is just a temporary workaround while we are also fixing root cause in `ngc` - tracked as FW-2199. Resolves FW-2198. Related to FW-2196 PR Close angular#37317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #37221 we disabled tsickle passes from transforming the tsc output that is used to publish all
Angular framework and components packages (@angular/*).
This change however revealed a bug in the ngc that caused __decorate and __metadata calls to still
be emitted in the JS code even though we don't depend on them.
Additionally it was these calls that caused code in @angular/material packages to fail at runtime
due to circular dependency in the emitted decorator code documeted as
microsoft/TypeScript#27519.
This change partially rolls back #37221 by reenabling the decorator to static fields (static
properties) downleveling.
This is just a temporary workaround while we are also fixing root cause in
ngc- tracked asFW-2199.
Resolves FW-2198.
Related to FW-2196