Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore(build): experimental Docker support for our build#7501

Closed
alexeagle wants to merge 1 commit into
angular:masterangular/angular:masterfrom
alexeagle:dockeralexeagle/angular:dockerCopy head branch name to clipboard
Closed

chore(build): experimental Docker support for our build#7501
alexeagle wants to merge 1 commit into
angular:masterangular/angular:masterfrom
alexeagle:dockeralexeagle/angular:dockerCopy head branch name to clipboard

Conversation

@alexeagle

Copy link
Copy Markdown
Contributor

No description provided.

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 9, 2016
@alexeagle

Copy link
Copy Markdown
Contributor Author

/cc @edgeprod

Comment thread Dockerfile Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .clean.json please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that reduces the changes seen, but need to copy to npm-shrinkwrap.json so npm install will see it, right?

@IgorMinar

Copy link
Copy Markdown
Contributor

Lgtm otherwise

@alexeagle alexeagle force-pushed the docker branch 5 times, most recently from 9837762 to 65d7c4a Compare March 9, 2016 04:34
@alexeagle

Copy link
Copy Markdown
Contributor Author

Will leave this work on the docker branch, and not merge to master yet.

@alexeagle alexeagle closed this Mar 9, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.