Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

TypeScript 1.6#4359

Closed
vsavkin wants to merge 3 commits into
angular:masterangular/angular:masterfrom
vsavkin:ts1.6vsavkin/angular:ts1.6Copy head branch name to clipboard
Closed

TypeScript 1.6#4359
vsavkin wants to merge 3 commits into
angular:masterangular/angular:masterfrom
vsavkin:ts1.6vsavkin/angular:ts1.6Copy head branch name to clipboard

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Sep 24, 2015

No description provided.

@vsavkin vsavkin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed cla: yes labels Sep 24, 2015
vicb
vicb reviewed Sep 25, 2015
View reviewed changes
Comment thread docs/typescript-package/services/tsParser/index.js Outdated
Copy link
Copy Markdown
Contributor

@vicb vicb Sep 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch

Copy link
Copy Markdown
Contributor Author

@vsavkin vsavkin Sep 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alexeagle
Copy link
Copy Markdown
Contributor

alexeagle commented Sep 25, 2015

sorry some of the cleanup items are leftover from my commits...

@alexeagle alexeagle added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 25, 2015
@alexeagle alexeagle assigned vsavkin and unassigned alexeagle Sep 25, 2015
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 25, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 25, 2015

Merging PR #4359 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4359.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 25, 2015
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsavkin @alexeagle @mary-poppins @pkozlowski-opensource @vicb @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.