Commit 812355c
perf(core): do not recurse into modules that have already been registered (#39514)
When registering an NgModule based on its id, all transitively imported
NgModules are also registered. This commit introduces a visited set to
avoid traversing into NgModules that are reachable from multiple import
paths multiple times.
Fixes #39487
PR Close #395141 parent 71d0063 commit 812355cCopy full SHA for 812355c
File tree
Expand file treeCollapse file tree
2 files changed
+24
-16
lines changedOpen diff view settings
Filter options
- packages/core
- src/linker
- test/render3
Expand file treeCollapse file tree
2 files changed
+24
-16
lines changedOpen diff view settings
Collapse file
packages/core/src/linker/ng_module_factory_registration.ts
Copy file name to clipboardExpand all lines: packages/core/src/linker/ng_module_factory_registration.ts+22-14Lines changed: 22 additions & 14 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
8 | 8 | |
9 | 9 | |
10 | 10 | |
11 | | - |
| 11 | + |
12 | 12 | |
| 13 | + |
13 | 14 | |
14 | 15 | |
15 | 16 | |
| ||
39 | 40 | |
40 | 41 | |
41 | 42 | |
42 | | - |
43 | | - |
44 | | - |
45 | | - |
46 | | - |
47 | | - |
48 | | - |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
49 | 56 | |
50 | | - |
51 | | - |
52 | | - |
53 | | - |
54 | | - |
55 | | - |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
| 61 | + |
| 62 | + |
| 63 | + |
56 | 64 | |
57 | 65 | |
58 | 66 | |
|
Collapse file
packages/core/test/render3/providers_spec.ts
Copy file name to clipboardExpand all lines: packages/core/test/render3/providers_spec.ts+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
6 | 6 | |
7 | 7 | |
8 | 8 | |
9 | | - |
| 9 | + |
10 | 10 | |
11 | 11 | |
12 | 12 | |
| ||
1092 | 1092 | |
1093 | 1093 | |
1094 | 1094 | |
1095 | | - |
| 1095 | + |
1096 | 1096 | |
1097 | 1097 | |
1098 | 1098 | |
|
0 commit comments