perf(core): do not recurse into modules that have already been registered#39514
Closed
JoostK wants to merge 2 commits intoangular:masterangular/angular:masterfrom
Closed
perf(core): do not recurse into modules that have already been registered#39514JoostK wants to merge 2 commits intoangular:masterangular/angular:masterfrom
JoostK wants to merge 2 commits intoangular:masterangular/angular:masterfrom
Conversation
6fe6a7f to
4e57dee
Compare
AndrewKushnir
approved these changes
Oct 30, 2020
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Nice optimization @JoostK 👍 (just left 1 minor comment)
Contributor
There was a problem hiding this comment.
Suggested change
| const def = getNgModuleDef(ngModuleType, true); | |
| const def = getNgModuleDef(ngModuleType, /* throwNotFound */ true); |
May be also add a quick comment on why it's safe to throw if moduleDef is not found?
Contributor
…ered When registering an NgModule based on its id, all transitively imported NgModules are also registered. This commit introduces a visited set to avoid traversing into NgModules that are reachable from multiple import paths multiple times. Fixes angular#39487
af1412e to
2b05235
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering an NgModule based on its id, all transitively imported
NgModules are also registered. This commit introduces a visited set to
avoid traversing into NgModules that are reachable from multiple import
paths multiple times.
Fixes #39487