This repository was archived by the owner on Feb 26, 2023. It is now read-only.
handle @Extra after @Bean#929
Closed
dodgex wants to merge 5 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:handle_extras_after_beansCopy head branch name to clipboard
Closed
handle @Extra after @Bean#929dodgex wants to merge 5 commits intoandroidannotations:developandroidannotations/androidannotations:developfrom dodgex:handle_extras_after_beansCopy head branch name to clipboard
dodgex wants to merge 5 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:handle_extras_after_beansCopy head branch name to clipboard
Conversation
Member
|
Can you please rebase your commits? |
Member
Author
Member
|
Please force push the new commit to this PR or open a new PR so we can merge as a pull request. It is easier to write down contributors with just looking at merged PRs, if we just merge a branch that info can be easily lost. |
Member
Author
|
i opened a new PR. i hope for the next time i learned the rebasing stuff to clean a PR. sorry for the trouble |
Member
|
No problem, thanks for your efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows the @AfterExtras annotated methods to have @bean values set.
related to: #928