This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Remove restErrorHandler field in rest service if not necessary#894
Merged
DayS merged 1 commit intoMay 11, 2014
androidannotations:developandroidannotations/androidannotations:developfrom
yDelouis:removeUselessErrorHandleryDelouis/androidannotations:removeUselessErrorHandlerCopy head branch name to clipboard
Merged
Remove restErrorHandler field in rest service if not necessary#894DayS merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom yDelouis:removeUselessErrorHandleryDelouis/androidannotations:removeUselessErrorHandlerCopy head branch name to clipboard
DayS merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
yDelouis:removeUselessErrorHandleryDelouis/androidannotations:removeUselessErrorHandlerCopy head branch name to clipboard
Conversation
Contributor
|
Yep, I mentioned it in #888. Thanks for the fix |
Contributor
|
Merged. Thanks. I resolved the conflict during the merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the interface annotated with
@Restdoesn't extendsRestClientErrorHandling, the fieldrestErrorHandlerwon't be assigned and will be always null. So, we shouldn't create it in the generated class and we should remove all thetry-catch.That's what does this PR.