This repository was archived by the owner on Feb 26, 2023. It is now read-only.
475 add missing rest authentication#711
Merged
DayS merged 2 commits intoOct 12, 2013
androidannotations:developandroidannotations/androidannotations:developfrom
dhleong:475_Add_Missing_Rest_Authenticationdhleong/androidannotations:475_Add_Missing_Rest_AuthenticationCopy head branch name to clipboard
Merged
475 add missing rest authentication#711DayS merged 2 commits intoandroidannotations:developandroidannotations/androidannotations:developfrom dhleong:475_Add_Missing_Rest_Authenticationdhleong/androidannotations:475_Add_Missing_Rest_AuthenticationCopy head branch name to clipboard
DayS merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
dhleong:475_Add_Missing_Rest_Authenticationdhleong/androidannotations:475_Add_Missing_Rest_AuthenticationCopy head branch name to clipboard
Conversation
Contributor
|
Unit tests are broken with this :) |
Contributor
|
Completed handling responses with DELETE and PUT HTTP Methods. #748 I dont think there's a need to do JUnit tests for this as its just refactoring. |
Contributor
|
I fixed the unit test and did some refactoring. For next time, please start a new branch from develop instead of your old branch :) |
Contributor
|
sure, was in a hurry to get the above fixed. Hope it helped.! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Delete/Head/Options methods were not being processed properly for the
@RequiresHeaderannotation (or, really, anything that used theHttpEntity). This pull request should fix that.(See #475)