Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix @ItemClick and parametrized types #627

Merged
DayS merged 2 commits into from
Jun 18, 2013
Merged

Fix @ItemClick and parametrized types #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa593ba
Fix wrong generated code
yDelouis Jun 12, 2013
aee786f
Add functional test
yDelouis Jun 17, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions 10 ...ndroidannotations/src/main/java/org/androidannotations/processing/ItemClickProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import javax.lang.model.type.TypeMirror;

import org.androidannotations.annotations.ItemClick;
import org.androidannotations.helper.APTCodeModelHelper;
import org.androidannotations.helper.IdAnnotationHelper;
import org.androidannotations.processing.EBeansHolder.Classes;
import org.androidannotations.rclass.IRClass;
Expand All @@ -48,6 +49,7 @@
public class ItemClickProcessor implements DecoratingElementProcessor {

private IdAnnotationHelper helper;
private final APTCodeModelHelper codeModelHelper = new APTCodeModelHelper();

public ItemClickProcessor(ProcessingEnvironment processingEnv, IRClass rClass) {
helper = new IdAnnotationHelper(processingEnv, getTarget(), rClass);
Expand Down Expand Up @@ -90,8 +92,12 @@ public void process(Element element, JCodeModel codeModel, EBeanHolder holder) {
if (parameterType.getKind() == TypeKind.INT) {
itemClickCall.arg(onItemClickPositionParam);
} else {
String parameterTypeQualifiedName = parameterType.toString();
itemClickCall.arg(cast(holder.refClass(parameterTypeQualifiedName), invoke(onItemClickParentParam, "getAdapter").invoke("getItem").arg(onItemClickPositionParam)));
JClass parameterClass = codeModelHelper.typeMirrorToJClass(parameterType, holder);
itemClickCall.arg(cast(parameterClass, invoke(onItemClickParentParam, "getAdapter").invoke("getItem").arg(onItemClickPositionParam)));

if (parameterClass.isParameterized()) {
onItemClickMethod.annotate(SuppressWarnings.class).param("value", "unchecked");
}
}
}

Expand Down
20 changes: 15 additions & 5 deletions 20 ...-1-5-tests/src/test/java/org/androidannotations/test15/ItemClicksHandledActivityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@
*/
package org.androidannotations.test15;

import static org.fest.assertions.Assertions.assertThat;

import android.view.View;
import android.widget.ListView;
import android.widget.Spinner;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;

import android.view.View;
import android.widget.ListView;
import android.widget.Spinner;
import static org.fest.assertions.Assertions.assertThat;

@RunWith(AndroidAnnotationsTestRunner.class)
public class ItemClicksHandledActivityTest {
Expand Down Expand Up @@ -117,4 +116,15 @@ public void can_have_one_selected_argument() {
assertThat(activity.listViewWithOneParamItemSelected).isTrue();
}

@Test
public void handlingListViewItemClickWithParametrizedItem() {
ListView listView = (ListView) activity.findViewById(R.id.listViewWithArgumentWithParameterType);
long itemId = listView.getAdapter().getItemId(TESTED_CLICKED_INDEX);
View view = listView.getChildAt(TESTED_CLICKED_INDEX);

assertThat(activity.listViewParametrizedItemClicked).isFalse();
listView.performItemClick(view, TESTED_CLICKED_INDEX, itemId);
assertThat(activity.listViewParametrizedItemClicked).isTrue();
}

}
6 changes: 6 additions & 0 deletions 6 AndroidAnnotations/functional-test-1-5/res/layout/item_clicks_handled.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@
android:layout_width="fill_parent"
android:layout_height="wrap_content"
/>

<ListView
android:id="@+id/listViewWithArgumentWithParameterType"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
/>

<ListView
android:id="@+id/listViewWithPosition"
Expand Down
47 changes: 35 additions & 12 deletions 47 ...ional-test-1-5/src/main/java/org/androidannotations/test15/ItemClicksHandledActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,10 @@
import android.widget.ArrayAdapter;
import android.widget.ListView;
import android.widget.Spinner;
import org.androidannotations.annotations.*;

import org.androidannotations.annotations.AfterViews;
import org.androidannotations.annotations.EActivity;
import org.androidannotations.annotations.ItemClick;
import org.androidannotations.annotations.ItemLongClick;
import org.androidannotations.annotations.ItemSelect;
import org.androidannotations.annotations.ViewById;
import java.util.ArrayList;
import java.util.List;

@EActivity(R.layout.item_clicks_handled)
public class ItemClicksHandledActivity extends Activity {
Expand All @@ -39,17 +36,21 @@ public class ItemClicksHandledActivity extends Activity {
@ViewById
ListView listViewWithArgument;

@ViewById
ListView listViewWithArgumentWithParameterType;

@ViewById
Spinner spinnerWithArgument;

@ViewById
ListView listViewWithPosition;

@ViewById
ListView listViewWithOneParam;

boolean spinnerItemClicked = false;
boolean listViewItemClicked = false;
boolean listViewParametrizedItemClicked = false;

String spinnerWithArgumentSelectedItem = null;
String listViewWithArgumentSelectedItem = null;
Expand All @@ -60,18 +61,23 @@ public class ItemClicksHandledActivity extends Activity {
int listViewWithPositionItemSelectedPosition;

private ArrayAdapter<CharSequence> adapter;
private ArrayAdapter<ArrayList<String>> parametrizedAdapter;

boolean listViewWithOneParamItemSelected;

@AfterViews
void initView() {
adapter = ArrayAdapter.createFromResource(this, R.array.planets_array, R.layout.simple_spinner_item);
adapter = ArrayAdapter.createFromResource(this, R.array.planets_array,
R.layout.simple_spinner_item);
adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);

parametrizedAdapter = new ArrayAdapter<ArrayList<String>>(this, android.R.layout.simple_list_item_1, stringLists());

spinner.setAdapter(adapter);
listView.setAdapter(adapter);
spinnerWithArgument.setAdapter(adapter);
listViewWithArgument.setAdapter(adapter);
listViewWithArgumentWithParameterType.setAdapter(parametrizedAdapter);
listViewWithPosition.setAdapter(adapter);
listViewWithOneParam.setAdapter(adapter);
spinnerItemClicked = false;
Expand All @@ -92,6 +98,11 @@ public void listViewWithArgument(String selectedItem) {
listViewWithArgumentSelectedItem = selectedItem;
}

@ItemClick(R.id.listViewWithArgumentWithParameterType)
protected void listViewWithArgumentWithParameterType(ArrayList<String> item) {
listViewParametrizedItemClicked = true;
}

@ItemClick
public void spinner() {
spinnerItemClicked = true;
Expand All @@ -101,26 +112,38 @@ public void spinner() {
public void spinnerWithArgument(String selectedItem) {
spinnerWithArgumentSelectedItem = selectedItem;
}

@ItemClick
void listViewWithPosition(int position) {
listViewWithPositionClickedPosition = position;
}

@ItemSelect
void listViewWithPositionItemSelected(boolean selected, int position) {
listViewWithPositionItemSelected = selected;
listViewWithPositionItemSelectedPosition = position;
}

@ItemSelect
void listViewWithOneParamItemSelected(boolean selected) {
listViewWithOneParamItemSelected = selected;
}

@ItemLongClick
void listViewWithPositionItemLongClicked(int position) {

}

private List<ArrayList<String>> stringLists() {
List<ArrayList<String>> stringLists = new ArrayList<ArrayList<String>>();
for (int i = 0; i < 10; i++) {
ArrayList<String> stringList = new ArrayList<String>();
for (int j = 0; j < 4; j++) {
stringList.add(i + " : " + j);
}
stringLists.add(stringList);
}
return stringLists;
}

}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.