This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Serialized @Background task cancellation bugfix#624
Merged
DayS merged 1 commit intoJun 10, 2013
androidannotations:developandroidannotations/androidannotations:developfrom
rom1v:cancel_background_fixrom1v/androidannotations:cancel_background_fixCopy head branch name to clipboard
Merged
Serialized @Background task cancellation bugfix#624DayS merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom rom1v:cancel_background_fixrom1v/androidannotations:cancel_background_fixCopy head branch name to clipboard
DayS merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
rom1v:cancel_background_fixrom1v/androidannotations:cancel_background_fixCopy head branch name to clipboard
Conversation
If a serialized @background task was cancelled after it had been submitted to the executor but before its run() method was called, then the following tasks with the same serial identifier were not executed. Issue reported here: androidannotations#579 (comment) Detected by ThreadActivityTest#cancellableSerializedBackgroundTasks() (but not always due to the race condition)
Contributor
|
My own tests works fine with this fix. |
DayS
added a commit
that referenced
this pull request
Jun 10, 2013
Serialized @background task cancellation bugfix
Contributor
|
Thanks for the quick fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fix a bug found in my serial+cancellable tasks feature.
If a serialized
@Backgroundtask was cancelled after it had beensubmitted to the executor but before its
run()method was called, thenthe following tasks with the same serial identifier were not executed.
Issue reported here:
#579 (comment)
Detected by
ThreadActivityTest#cancellableSerializedBackgroundTasks()(but not always due to the race condition)
I ran the tests 50 times (in a loop):
Thank you to dhleong for reporting it so quickly after the merge.