This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Merge pull for Issue #588, user DatabaseHelper.getDao instead of DaoManager.createDao()#596
Closed
gebing wants to merge 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
gebing:588_OrmLiteDaoCopy head branch name to clipboard
Closed
Merge pull for Issue #588, user DatabaseHelper.getDao instead of DaoManager.createDao()#596gebing wants to merge 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom gebing:588_OrmLiteDaoCopy head branch name to clipboard
gebing wants to merge 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
gebing:588_OrmLiteDaoCopy head branch name to clipboard
Conversation
Contributor
|
You shouldn't merge your branch before sending a pull-request. It's ou job to merge it. |
Contributor
Author
|
My develop branch is forked from androidannotations's develop branch, and later I merged some new commits from androidannotations's develop branch. And I created a new branch from that merged develop branch of mine, and commit my changes on this branch, and push it on my fork. That's all what i did. i didn't merge my newly create branch, and how should i? |
Contributor
Contributor
Author
|
i make a new fork from androidannotation, make a new branch of 588_OrmLiteDao and make a new Pull Reqeust #597 |
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify @OrmLite to use database helper to get dao, so generate code will look like:
...
...
helper_ = OpenHelperManager.getHelper(this, DatabaseHelper.class);
try {
clickCountDao = helper_.getDao(ClickCount.class);
} catch (SQLException e) {
Log.e("MyActivity_", "Could not create DAO clickCountDao", e);
}