CustomTitle annotation added#376
CustomTitle annotation added#376pyricau merged 7 commits intoandroidannotations:developandroidannotations/androidannotations:developfrom Bersh:customTitleCopy head branch name to clipboard
Conversation
|
Hi ! Thank you for contributing, it's nice of you. I will have a look at your pull request. Please note, however, that it would be nice if you could start by posting an issue to discuss the idea and implementation before going directly with a pull request. |
There was a problem hiding this comment.
These changes have no relation with the subject of the pull request and doesn't match our coding standards (no wildcard imports).
|
Thanks for your comments! I'll try to fix it when I'll have free time |
|
Ok :) . You'll also notice that we just changed all the packages from |
|
At last I managed to fix my changes. I've had some problems with merging, but everything should be fine now. Unfortunately, because of this problems I can see some unneeded commits as added. I've no idea how i can fix it, so excuse me for adding unnecessary commits. My last changes should contains only 17937a0 and 35b94f4 commits |
|
Well, if you don't know how to clean a Git history, then better not do it and keep it this way ;) . I'll have a look and merge when I have more time (maybe on thursday). |
There was a problem hiding this comment.
Use it on activities to set a custom layout
|
Other then these two comments, this looks nice. Once you're done, I'll checkout the code, check that everything works fine, and then merge. |
|
Doc updated: @CustomTitle |
Hi!
This is my first pull request so excuse if something wrong.
I've add CustomTitle annotation which allows to specify custom title layout for activity