Provide Activity scope for @EBean#2206
Provide Activity scope for @EBean#2206WonderCsabo merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom smaugho:1488_provide_activity_scope_for_ebeansmaugho/androidannotations:1488_provide_activity_scope_for_ebeanCopy head branch name to clipboard
Conversation
WonderCsabo
left a comment
There was a problem hiding this comment.
Nice work, thanks!
Please add compile time and runtime tests.
Also, please use the imperative mood for git commit messages ("Add something" and not "Adds something").
8b8027c to
af57bfe
Compare
|
I added all the tests, did also some organization in existing tests, so please have a look to it. Note that the "Cyclic Tests" are using a Fragment now done only for that end. Also added "Scope Tests" and moved some existing tests related to the "Singleton" scope under that one. |
635ade8 to
9ef43ae
Compare
|
@smaugho this should be rebased, right? |
|
It should be rebased. But I would wait to merging #2202 , since it depends on it as well, so that I have to rebase only once. |
|
#2202 has been merged. could you please rebase and ensure the conflicts are gone? thanks :) |
|
@WonderCsabo you still have requested changes here. are they resolved but you missed to update your review or are the changes still pending? |
|
@dodgex i think they were resolved, waiting for rebase now. :) |
|
@WonderCsabo okay, after rebase approve the PR and then I'll review. |
|
Gonna rebase now 👍 |
9ef43ae to
3ff98e4
Compare
This PR adds the scope Activity and scope Fragment to the
@EBeanannotation, solving #1488Please note, that this PR is for a revision, cause' it depends on #2202 . Once I get #2202, I should make a rebase, and then this one would be ready to merge.
But please, have a look at it, and provide feedback if possible.
Thanks!