This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Check a full name instead of just the classSuffix#2167
Merged
WonderCsabo merged 1 commit intoOct 14, 2018
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:fix_jdk_11_buildCopy head branch name to clipboard
Merged
Check a full name instead of just the classSuffix#2167WonderCsabo merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom dodgex:fix_jdk_11_buildCopy head branch name to clipboard
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:fix_jdk_11_buildCopy head branch name to clipboard
Conversation
WonderCsabo
suggested changes
Oct 14, 2018
| } | ||
|
|
||
| if (!SourceVersion.isName(classSuffix) || classSuffix.contains(".")) { | ||
| if (!SourceVersion.isName("validName" + classSuffix) || classSuffix.contains(".")) { |
Member
There was a problem hiding this comment.
I would capitalize ValidName.
…no longer valid in JDK 11 (and mabye 10?)
Member
Author
|
Updated :) |
WonderCsabo
approved these changes
Oct 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as a single '_' is no longer valid in JDK 11 (and mabye 10?)